From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Thu, 20 May 2010 10:38:48 +0200 Subject: [U-Boot] [PATCH 1/1] flash: Check info pointer in flash_protect(). In-Reply-To: <1274160395-9308-2-git-send-email-mark.tomlinson@alliedtelesis.co.nz> References: <1274160395-9308-1-git-send-email-mark.tomlinson@alliedtelesis.co.nz> <1274160395-9308-2-git-send-email-mark.tomlinson@alliedtelesis.co.nz> Message-ID: <20100520083848.5667DCCF026@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mark Tomlinson, In message <1274160395-9308-2-git-send-email-mark.tomlinson@alliedtelesis.co.nz> you wrote: > Some calls to flash_protect() do not check that info is not > NULL. This change prevents this from causing random memory to > be stomped on. When exactly would that be the case? > NOTICE: This message contains privileged and confidential > information intended only for the use of the addressee > named above. If you are not the intended recipient of ... Such terms are obviously unacceptable for any code that is supposed to go into mainline. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The C-shell doesn't parse. It adhoculates. - Casper.Dik at Holland.Sun.COM in <3ol96k$b2j@engnews2.Eng.Sun.COM>