From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library
Date: Sat, 22 May 2010 00:29:47 +0200 [thread overview]
Message-ID: <20100521222947.DA6BDCCF026@gemini.denx.de> (raw)
In-Reply-To: <FA771A99-42EA-4299-9DE1-77AFC32734B2@kernel.crashing.org>
Dear Kumar Gala,
In message <FA771A99-42EA-4299-9DE1-77AFC32734B2@kernel.crashing.org> you wrote:
>
> >> +{
> >> + const unsigned long input_freq = CONFIG_ICS307_REFCLK_HZ;
> >> + unsigned long VDW = ((cw1 << 1) & 0x1FE) + ((cw2 >> 7) & 1);
> >> + unsigned long RDW = cw2 & 0x7F;
> >> + unsigned long OD = ics307_s_to_od[cw0 & 0x7];
> >> + unsigned long freq;
> >
> > Wolfgang just asked me not to use camel caps.
>
> where are there camel caps?
There aren't. But we do not allow for ALLCAPS identifiers either
(these are reserved for macro names).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Behind every great man, there is a woman -- urging him on.
-- Harry Mudd, "I, Mudd", stardate 4513.3
next prev parent reply other threads:[~2010-05-21 22:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 9:18 [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library Kumar Gala
2010-05-21 9:18 ` [U-Boot] [PATCH] ppc/85xx: Convert MPC8572DS to using board common ICS307 code Kumar Gala
2010-05-21 9:18 ` [U-Boot] [PATCH] ppc/85xx: Convert MPC8536DS " Kumar Gala
2010-05-21 15:57 ` [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library Timur Tabi
2010-05-21 22:19 ` Kumar Gala
2010-05-21 22:29 ` Wolfgang Denk [this message]
2010-05-21 22:22 ` Kumar Gala
2010-05-21 22:35 ` Wolfgang Denk
2010-05-21 18:42 ` Timur Tabi
2010-05-22 22:41 ` Kumar Gala
2010-05-21 18:59 ` Timur Tabi
2010-05-21 19:35 ` Timur Tabi
2010-05-21 19:52 ` Wolfgang Denk
2010-05-21 19:58 ` Timur Tabi
2010-05-21 20:16 ` Wolfgang Denk
2010-05-21 20:28 ` Timur Tabi
2010-05-21 21:03 ` Wolfgang Denk
2010-05-21 21:09 ` Timur Tabi
2010-05-22 22:39 ` Kumar Gala
2010-05-22 22:36 ` [U-Boot] [PATCH v2] " Kumar Gala
2010-05-24 14:52 ` Timur Tabi
2010-05-24 18:57 ` Kumar Gala
2010-05-24 19:06 ` Timur Tabi
2010-05-24 20:09 ` [U-Boot] [PATCH v3] " Kumar Gala
2010-05-24 20:12 ` Timur Tabi
2010-06-30 9:52 ` Kumar Gala
2010-07-14 19:33 ` Wolfgang Denk
2010-07-14 21:21 ` [U-Boot] [PATCH v4] Move ICS CLK chip frequency " Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100521222947.DA6BDCCF026@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox