From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 26 May 2010 22:19:04 +0200 Subject: [U-Boot] [PATCH] arm:io.h: define __io() macro if not defined erlier In-Reply-To: <201005261350.16464.vapier@gentoo.org> References: <1274259427-29386-1-git-send-email-biessmann@corscience.de> <20100525112907.0E0A9E22AD1@gemini.denx.de> <4BFCEEA1.3080202@corscience.de> <201005261350.16464.vapier@gentoo.org> Message-ID: <20100526201904.E671CEAC238@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Frysinger, In message <201005261350.16464.vapier@gentoo.org> you wrote: > > i changed the accessors to use in/out macros as i thought that was the correct > set of accessor functions to use. looking at a set of definitions and picking > a set because they look like they'll "just work" isnt how i set about it. > > after having read the deviceiobook in the Linux kernel, i think the correct > funcs to use here are the read/write helpers. now that i have that > information, looking at the definitions shows that this should work for ARM > just fine. > > so, to be clear, i think we should do: > -#define DM9000_outb(d,r) outb(d, r) > +#define DM9000_outb(d,r) writeb(d, r) > etc... This seems to work for me. Will send a patch to do this ASAP. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I am a computer. I am dumber than any human and smarter than any ad- ministrator.