From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Thu, 27 May 2010 09:08:46 +0200 Subject: [U-Boot] [PATCH] 85xx/p2020ds: Use is_serdes_configured() to determine of PCIe enabled In-Reply-To: <1274433478-31849-2-git-send-email-galak@kernel.crashing.org> References: <1274433478-31849-1-git-send-email-galak@kernel.crashing.org> <1274433478-31849-2-git-send-email-galak@kernel.crashing.org> Message-ID: <20100527070846.85882EAC238@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Kumar Gala, In message <1274433478-31849-2-git-send-email-galak@kernel.crashing.org> you wrote: > The new is_serdes_configured covers a broader range of devices than the > PCI specific code. Use it instead as we convert away from the > is_fsl_pci_cfg() code. > > Additionally move to setting LAWs for PCI based on if its configured. > Also updated PCI FDT fixup code to remove PCI controllers from dtb if > they are not configured. ... > #ifdef CONFIG_PCIE3 > ft_fsl_pci_setup(blob, "pci0", &pcie3_hose); > +#else > + ft_fsl_pci_setup(blob, "pci0", NULL); > #endif > #ifdef CONFIG_PCIE2 > ft_fsl_pci_setup(blob, "pci1", &pcie2_hose); > +#else > + ft_fsl_pci_setup(blob, "pci1", NULL); > #endif > #ifdef CONFIG_PCIE1 > ft_fsl_pci_setup(blob, "pci2", &pcie1_hose); > +#else > + ft_fsl_pci_setup(blob, "pci2", NULL); > #endif As Timur already pointed out: can we please clean up this mess of 3 = 0 = 3, 2 = 1 = 2, 1 = 2 = 1? This is extremely confusing. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de He had been eight years upon a project for extracting sunbeams out of cucumbers, which were to be put in vials hermetically sealed, and let out to warm the air in raw inclement summers. - Jonathan Swift _Gulliver's Travels_ ``A Voyage to Laputa, etc.'' ch. 5