From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Thu, 27 May 2010 23:03:26 +0200
Subject: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS
	reference board
In-Reply-To: <4BFED090.1040305@freescale.com>
References: <1274392909-16422-1-git-send-email-timur@freescale.com>
	<20100520223324.50594CCF026@gemini.denx.de>
	<4BFC1736.5030902@freescale.com>
	<20100526201014.97886EAC238@gemini.denx.de>
	<4BFD837D.2040508@freescale.com>
	<20100527070235.E8812EAC238@gemini.denx.de>
	<4BFE823A.1080409@freescale.com>
	<20100527181118.3C9F7EAC238@gemini.denx.de>
	<4BFEB922.9040106@freescale.com>
	<20100527190340.GA5915@schlenkerla.am.freescale.net>
	<20100527195318.71B5EEAC238@gemini.denx.de>
	<4BFED090.1040305@freescale.com>
Message-ID: <20100527210326.6459FEAC238@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Scott Wood,

In message <4BFED090.1040305@freescale.com> you wrote:
>
> If you set maxsize beyond what you expect to find, how are you going to 
> constrain it to operating on one bank?

Maybe it helps if you read section "System Initialization" in teh
README; this explains the original design when I implemented this a
decade ago.

> > Such configurations are usually set up of from several differently
> > sized banks of memory, and get_ram_size() is always run per bank. So
> > as long as chip manufacturers continue to make RAM chips with
> > power-of-two sizes only, everything should be fine.
> 
> So it's not the board code at all that should be calling this, it's the 
> SDRAM code?  Which is already in u-boot, and not in this patch (other 
> than some board-specific tweaks)?

I don't know where you initialize the RAM.

> Let's not.  It can be crowded enough as is, we don't need more 
> restrictions coming from u-boot wanting to do questionable and 
> unnecessary things.

Well, what seems unnecessary to you is actually pretty important to
others.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I realize that command does have its fascination, even under  circum-
stances such as these, but I neither enjoy the idea of command nor am
I  frightened  of  it. It simply exists, and I will do whatever logi-
cally needs to be done.
	-- Spock, "The Galileo Seven", stardate 2812.7