From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kim Phillips Date: Tue, 8 Jun 2010 12:09:32 -0500 Subject: [U-Boot] [PATCH V2 03/10] 83xx/85xx/86xx: LBC register cleanup In-Reply-To: <3CDDBC61-CE75-4EE0-963B-6E0B8211B044@kernel.crashing.org> References: <1275502329-23457-1-git-send-email-beckyb@kernel.crashing.org> <1275502329-23457-2-git-send-email-beckyb@kernel.crashing.org> <1275502329-23457-3-git-send-email-beckyb@kernel.crashing.org> <1275502329-23457-4-git-send-email-beckyb@kernel.crashing.org> <20100603193751.0bf13487.kim.phillips@freescale.com> <3CDDBC61-CE75-4EE0-963B-6E0B8211B044@kernel.crashing.org> Message-ID: <20100608120932.49ada87f.kim.phillips@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, 8 Jun 2010 11:15:07 -0500 Becky Bruce wrote: > This isn't *ELBC*, it's the existence of any sort of LBC. ELBC is > determined per-board in the fine grained configs. There are 2 configs. that's what I was suggesting to change; to group and centralize the definition of the two seemingly related configs - also because the ELBC should be done at the SoC level. See Scott's response though - I don't know how long the ELBC ifdef list is, but introducing a header file per soc sounds like a bit out of scope for this patchseries - it already cleans up a bunch of stuff. > -B Kim p.s. please don't top-post :). > On Jun 3, 2010, at 7:37 PM, Kim Phillips wrote: > > > On Wed, 2 Jun 2010 13:12:02 -0500 > > Becky Bruce wrote: > > > >> diff --git a/arch/powerpc/include/asm/config.h b/arch/powerpc/ > >> include/asm/config.h > >> index fc3facb..01036f3 100644 > >> --- a/arch/powerpc/include/asm/config.h > >> +++ b/arch/powerpc/include/asm/config.h > >> @@ -76,4 +76,10 @@ > >> /* Relocation to SDRAM works on all PPC boards */ > >> #define CONFIG_RELOC_FIXUP_WORKS > >> > >> +/* Most PPC SOCs have a LBC so define this here */ > >> +#if defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx) || \ > >> + defined(CONFIG_MPC83xx) > >> +#define CONFIG_FSL_LBC > > > > Instead of in the configs (such as what patch 1 in this series > > continues to do), can we do ELBC determination here, based on > > finer-grained configs such as 831x, 837x, etc? > > > >> +#endif > > > > Thanks, > > > > Kim > >