public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Juergen Kilb <J.Kilb@phytec.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] smc91xx_eeprom: Correct chip detection check.
Date: Sat, 12 Jun 2010 21:22:01 +0200	[thread overview]
Message-ID: <20100612192201.17815.3486.stgit@numalfix> (raw)

From: Juergen Kilb <j.jilb@phytec.de>

The smc911x_detect function in /net/driver/net/smc911x.c
returns a 0 if everything was ok (a chip was found) and -1 else.
In the standalone example 'smc911x_eeprom' the return value
of smc911x_detect is interpreted in a different way
(0 for error, !0 as OK).
This leads to the error that the chip will not be detected.

Signed-of-by: Juergen Kilb <j.kilb@phytec.de>
---

 examples/standalone/smc911x_eeprom.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/examples/standalone/smc911x_eeprom.c b/examples/standalone/smc911x_eeprom.c
index 104047f..cb3c131 100644
--- a/examples/standalone/smc911x_eeprom.c
+++ b/examples/standalone/smc911x_eeprom.c
@@ -240,7 +240,7 @@ static void dump_eeprom(struct eth_device *dev)
 static int smc911x_init(struct eth_device *dev)
 {
 	/* See if there is anything there */
-	if (!smc911x_detect_chip(dev))
+	if (smc911x_detect_chip(dev))
 		return 1;
 
 	smc911x_reset(dev);

             reply	other threads:[~2010-06-12 19:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-12 19:22 Juergen Kilb [this message]
2010-06-13  2:28 ` [U-Boot] [PATCH] smc91xx_eeprom: Correct chip detection check Mike Frysinger
2010-06-21  6:10 ` Ben Warren
2010-07-09 22:11 ` Mike Frysinger
2010-07-09 23:31   ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100612192201.17815.3486.stgit@numalfix \
    --to=j.kilb@phytec.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox