public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 00/10] Add support for TI OMAP4 SDP and Panda
Date: Sat, 19 Jun 2010 00:19:58 +0200	[thread overview]
Message-ID: <20100618221958.114F4152447@gemini.denx.de> (raw)
In-Reply-To: <1276898035.15574.235.camel@quadra>

Dear Steve Sakoman,

In message <1276898035.15574.235.camel@quadra> you wrote:
> On Fri, 2010-06-18 at 16:10 -0500, Peter Tyser wrote:
...
> > It'd be preferred if you could reorganize the patch series to first make
> > all CPU/SOC changes, then finally do 1 patch for each board.  This is
> > generally considered cleaner than having patches bouncing back and forth
> > between common and board specific code.  Right now the SDP and Panda
> > boards each require 3 patches when 1 patch apiece should suffice.  eg:
> > ARM: Rename arch/arm/cpu/arm_cortexa8 to armv7
> > ARMV7: Add basic support for TI OMAP4
> > ARMV7: Restructure OMAP mmc driver to allow code sharing between OMAP3 and OMAP4
> > ARMV7: Restructure OMAP i2c driver to allow code sharing between OMAP3 and OMAP4
> > ARMV7: Add support for TI OMAP4430 SDP
> > ARMV7: Add support for TI OMAP4 Panda
> 
> In the past I've had complaints that I should break each piece of
> functionality into a separate patch :-)

Well, the rules are formulated as clear as I could (improvments always
welcome!) - please see "General Patch Submission Rules" bullet # 2 at
http://www.denx.de/wiki/U-Boot/Patches

> I'm happy to do whatever is preferred!  Wolfgang, would you like a v4
> with the proposed structure?

Yes, please. Peter is absolutely right.  And please keep in mind that
at each step in your patch series the code must be buildable and
runnable, so we can use git bisect to isolate problems.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the beginning there was nothing.
And the Lord said "Let There Be Light!"
And still there was nothing, but at least now you could see it.

  reply	other threads:[~2010-06-18 22:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-18 20:42 [U-Boot] [PATCH v3 00/10] Add support for TI OMAP4 SDP and Panda Steve Sakoman
2010-06-18 20:42 ` [U-Boot] [PATCH v3 01/10] ARM: Rename arch/arm/cpu/arm_cortexa8 to armv7 Steve Sakoman
2010-06-18 20:42 ` [U-Boot] [PATCH v3 02/10] ARMV7: Add basic support for TI OMAP4 Steve Sakoman
2010-06-18 20:42 ` [U-Boot] [PATCH v3 03/10] ARMV7: Add support for TI OMAP4430 SDP Steve Sakoman
2010-06-18 20:42 ` [U-Boot] [PATCH v3 04/10] ARMV7: Add support for TI OMAP4 Panda Steve Sakoman
2010-06-18 20:42 ` [U-Boot] [PATCH v3 05/10] ARMV7: Restructure OMAP mmc driver to allow code sharing between OMAP3 and OMAP4 Steve Sakoman
2010-06-18 20:42 ` [U-Boot] [PATCH v3 06/10] ARMV7: Enable mmc support on TI OMAP4430 SDP Steve Sakoman
2010-06-18 20:42 ` [U-Boot] [PATCH v3 07/10] ARMV7: Enable mmc support on TI OMAP4 Panda Steve Sakoman
2010-06-18 20:42 ` [U-Boot] [PATCH v3 08/10] ARMV7: Restructure OMAP i2c driver to allow code sharing between OMAP3 and OMAP4 Steve Sakoman
2010-06-18 20:42 ` [U-Boot] [PATCH v3 09/10] ARMV7: Enable i2c support on TI OMAP4 SDP Steve Sakoman
2010-06-18 20:42 ` [U-Boot] [PATCH v3 10/10] ARMV7: Enable i2c support on TI OMAP4 Panda Steve Sakoman
2010-06-18 21:10 ` [U-Boot] [PATCH v3 00/10] Add support for TI OMAP4 SDP and Panda Peter Tyser
2010-06-18 21:53   ` Steve Sakoman
2010-06-18 22:19     ` Wolfgang Denk [this message]
2010-06-18 22:36       ` Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100618221958.114F4152447@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox