From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sat, 19 Jun 2010 21:58:40 -0400 Subject: [U-Boot] [PATCH] include/compiler.h: remove redunandt declaration of errno In-Reply-To: <1276993233-12149-1-git-send-email-y> References: <1276993233-12149-1-git-send-email-y> Message-ID: <201006192158.42049.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday, June 19, 2010 20:20:33 y at denx.de wrote: > Commit 37566090 "compiler.h: unify system ifdef cruft here" added both > a "#include " and a "extern int errno;" to include/compiler.h it isnt new code, it sucked the definitions out of random files that had these and into one place > which is causing build warnings for some systems, for example for the > "netstar" board: > > In file included from /home/wd/git/u-boot/work/lib/crc32.c:15: > include/compiler.h:28: warning: function declaration isn't a prototype never seen that, but i imagine re-ordering the lines might address it as well (extern then include) > The declaration of "errno" should be redundant, as is > supposed to provide a correct declaration, so drop it. there are older systems where this isnt true, but ive never used one myself and if we dont care about them (i dont), then this is fine -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20100619/f9e6bbfb/attachment.pgp