[U-Boot] [PATCH 1/2] NAND: show manufacturer and device ID for unknown chips

[U-Boot] [PATCH 1/2] NAND: show manufacturer and device ID for unknown chips

[Florian Fainelli]

When the NAND part is not supported, it is useful to show the manufacturer
and device ID to help debugging and reporting.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 7171bdd..c1657de 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2652,8 +2652,12 @@ static struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd,
 		}
 	}
 
-	if (!type)
+	if (!type) {
+		printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID :"
+				" 0x%02x, Chip ID: 0x%02x\n", __func__,
+				*maf_id, dev_id);
 		return ERR_PTR(-ENODEV);
+	}
 
 	if (!mtd->name)
 		mtd->name = type->name;

[U-Boot] [PATCH 1/2] NAND: show manufacturer and device ID for unknown chips

[Florian Fainelli]

Le Saturday 12 June 2010 20:59:25, Florian Fainelli a ?crit :
> When the NAND part is not supported, it is useful to show the manufacturer
> and device ID to help debugging and reporting.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Scott, anything from with the patch? Thanks!

> ---
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 7171bdd..c1657de 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -2652,8 +2652,12 @@ static struct nand_flash_dev
> *nand_get_flash_type(struct mtd_info *mtd, }
>  	}
> 
> -	if (!type)
> +	if (!type) {
> +		printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID :"
> +				" 0x%02x, Chip ID: 0x%02x\n", __func__,
> +				*maf_id, dev_id);
>  		return ERR_PTR(-ENODEV);
> +	}
> 
>  	if (!mtd->name)
>  		mtd->name = type->name;

-- 
Florian

[U-Boot] [PATCH 1/2] NAND: show manufacturer and device ID for unknown chips

[Scott Wood]

On Sun, Jun 20, 2010 at 03:40:55PM +0200, Florian Fainelli wrote:
> Le Saturday 12 June 2010 20:59:25, Florian Fainelli a ?crit :
> > When the NAND part is not supported, it is useful to show the manufacturer
> > and device ID to help debugging and reporting.
> > 
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> Scott, anything from with the patch? Thanks!

I just got back from vacation, but the patches look reasonable.  

> > ---
> > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> > index 7171bdd..c1657de 100644
> > --- a/drivers/mtd/nand/nand_base.c
> > +++ b/drivers/mtd/nand/nand_base.c
> > @@ -2652,8 +2652,12 @@ static struct nand_flash_dev
> > *nand_get_flash_type(struct mtd_info *mtd, }
> >  	}
> > 
> > -	if (!type)
> > +	if (!type) {
> > +		printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID :"

I'd leave out the space before the colon ("foo: bar", not "foo : bar"),
though.  I think that may be a regional style issue, but let's stick with
what the rest of the code does.

-Scott