* [U-Boot] [PATCH 1/2] NAND: show manufacturer and device ID for unknown chips
@ 2010-06-12 18:59 Florian Fainelli
2010-06-20 13:40 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2010-06-12 18:59 UTC (permalink / raw)
To: u-boot
When the NAND part is not supported, it is useful to show the manufacturer
and device ID to help debugging and reporting.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 7171bdd..c1657de 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2652,8 +2652,12 @@ static struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd,
}
}
- if (!type)
+ if (!type) {
+ printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID :"
+ " 0x%02x, Chip ID: 0x%02x\n", __func__,
+ *maf_id, dev_id);
return ERR_PTR(-ENODEV);
+ }
if (!mtd->name)
mtd->name = type->name;
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH 1/2] NAND: show manufacturer and device ID for unknown chips
2010-06-12 18:59 [U-Boot] [PATCH 1/2] NAND: show manufacturer and device ID for unknown chips Florian Fainelli
@ 2010-06-20 13:40 ` Florian Fainelli
2010-06-21 16:49 ` Scott Wood
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2010-06-20 13:40 UTC (permalink / raw)
To: u-boot
Le Saturday 12 June 2010 20:59:25, Florian Fainelli a ?crit :
> When the NAND part is not supported, it is useful to show the manufacturer
> and device ID to help debugging and reporting.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Scott, anything from with the patch? Thanks!
> ---
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 7171bdd..c1657de 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -2652,8 +2652,12 @@ static struct nand_flash_dev
> *nand_get_flash_type(struct mtd_info *mtd, }
> }
>
> - if (!type)
> + if (!type) {
> + printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID :"
> + " 0x%02x, Chip ID: 0x%02x\n", __func__,
> + *maf_id, dev_id);
> return ERR_PTR(-ENODEV);
> + }
>
> if (!mtd->name)
> mtd->name = type->name;
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] [PATCH 1/2] NAND: show manufacturer and device ID for unknown chips
2010-06-20 13:40 ` Florian Fainelli
@ 2010-06-21 16:49 ` Scott Wood
0 siblings, 0 replies; 3+ messages in thread
From: Scott Wood @ 2010-06-21 16:49 UTC (permalink / raw)
To: u-boot
On Sun, Jun 20, 2010 at 03:40:55PM +0200, Florian Fainelli wrote:
> Le Saturday 12 June 2010 20:59:25, Florian Fainelli a ?crit :
> > When the NAND part is not supported, it is useful to show the manufacturer
> > and device ID to help debugging and reporting.
> >
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Scott, anything from with the patch? Thanks!
I just got back from vacation, but the patches look reasonable.
> > ---
> > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> > index 7171bdd..c1657de 100644
> > --- a/drivers/mtd/nand/nand_base.c
> > +++ b/drivers/mtd/nand/nand_base.c
> > @@ -2652,8 +2652,12 @@ static struct nand_flash_dev
> > *nand_get_flash_type(struct mtd_info *mtd, }
> > }
> >
> > - if (!type)
> > + if (!type) {
> > + printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID :"
I'd leave out the space before the colon ("foo: bar", not "foo : bar"),
though. I think that may be a regional style issue, but let's stick with
what the rest of the code does.
-Scott
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-21 16:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-12 18:59 [U-Boot] [PATCH 1/2] NAND: show manufacturer and device ID for unknown chips Florian Fainelli
2010-06-20 13:40 ` Florian Fainelli
2010-06-21 16:49 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox