public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] GTH board status
Date: Wed, 23 Jun 2010 23:34:06 +0200	[thread overview]
Message-ID: <20100623213406.DFA051524F4@gemini.denx.de> (raw)

Dear Thomas,

is the GTH board still actively being maintained, or what exactly is
it's state?

I'm trying to clean up a thing or two and ran into a few strange
things:

"common/env_common.c" has this:

230 #if defined(CONFIG_GTH) || defined(CONFIG_ENV_IS_NOWHERE)       /* Environment not changable */
231                 puts ("Using default environment\n\n");
232 #else
233                 puts ("*** Warning - bad CRC, using default environment\n\n");  
234                 show_boot_progress (-60);
235 #endif

This looks as if the GTH board had no persistent environment storage;
but when I was tempted to remove the "defined(CONFIG_GTH) ||" part
and add a "#define CONFIG_ENV_IS_NOWHERE" to "include/configs/GTH.h"
I see this:

197 #define CONFIG_ENV_IS_IN_FLASH 1
198 #undef CONFIG_ENV_IS_IN_EEPROM
199 #define CONFIG_ENV_OFFSET               0x000E0000
200 #define CONFIG_ENV_SIZE         0x4000  /* Total Size of Environment Sector     */
201
202 #define CONFIG_ENV_SECT_SIZE    0x50000 /* see README - env sector total size   */

That means that there is actually flash on the GTH board.

Do you agree that we simply remove the "defined(CONFIG_GTH) ||" part
from "common/env_common.c" ?


Then I noticed the CONFIG_ENV_SECT_SIZE = 0x50000 setting. I am sure
that your flash memory cannot have a sector size of 320 KiB - the
0x50000 must be bogus.

Please comment.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Use C++ to confuse your enemies; use C to produce stable code.

             reply	other threads:[~2010-06-23 21:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-23 21:34 Wolfgang Denk [this message]
2010-06-24  9:48 ` [U-Boot] GTH board status Thomas Lange
2010-06-24 18:49   ` Wolfgang Denk
2010-06-24 18:57     ` Thomas Lange
2010-06-29 20:06       ` [U-Boot] [PATCH] Drop support for GTH board Wolfgang Denk
2010-06-30 22:55         ` Thomas Lange
2010-07-04 22:07           ` Wolfgang Denk
2010-07-04 22:07         ` [U-Boot] [PATCH v2] " Wolfgang Denk
2010-07-04 22:29           ` Thomas Lange
2010-07-05 20:47             ` Wolfgang Denk
2010-07-05 20:46         ` [U-Boot] [PATCH v3] " Wolfgang Denk
2010-07-05 21:12           ` Thomas Lange
2010-07-17 18:47           ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100623213406.DFA051524F4@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox