From: Florian Fainelli <florian@openwrt.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] NAND: show manufacturer and device ID for unknown chips
Date: Thu, 24 Jun 2010 11:56:33 +0200 [thread overview]
Message-ID: <201006241156.33244.florian@openwrt.org> (raw)
In-Reply-To: <20100623215301.GA9212@schlenkerla.am.freescale.net>
Hey Scott,
On Wednesday 23 June 2010 23:53:01 Scott Wood wrote:
> From: Florian Fainelli <florian@openwrt.org>
>
> When the NAND part is not supported, it is useful to show the manufacturer
> and device ID to help debugging and reporting.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> Whitespace amended to be consistent with rest of file.
Thanks, I was just about to respin it.
>
> Applied to u-boot-nand-flash next.
>
> drivers/mtd/nand/nand_base.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 7171bdd..ed1c9c9 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -2652,8 +2652,12 @@ static struct nand_flash_dev
> *nand_get_flash_type(struct mtd_info *mtd, }
> }
>
> - if (!type)
> + if (!type) {
> + printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID:"
> + " 0x%02x, Chip ID: 0x%02x\n", __func__,
> + *maf_id, dev_id);
> return ERR_PTR(-ENODEV);
> + }
>
> if (!mtd->name)
> mtd->name = type->name;
prev parent reply other threads:[~2010-06-24 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 21:53 [U-Boot] [PATCH v2] NAND: show manufacturer and device ID for unknown chips Scott Wood
2010-06-24 9:56 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006241156.33244.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox