public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MPC512x: workaround data corruption for unaligned local bus accesses
Date: Tue, 29 Jun 2010 15:34:06 +0200	[thread overview]
Message-ID: <20100629153406.653b6bc0@wker> (raw)
In-Reply-To: <20100629124714.87A8314EBF8@gemini.denx.de>

Dear Wolfgang,

On Tue, 29 Jun 2010 14:47:14 +0200
Wolfgang Denk <wd@denx.de> wrote:

...
> > BTW, shouldn't we fix print_buffer() also? do_mem_md() doesn't use
> > memcpy() and the issue with corrupted dumps still remains here.
> > I'm testing a patch to fix it. Will submit it soon.
> 
> I though about this, too. But then I decided against it. "md" is
> intended to to exactly what the user requests - as is, we can easily
> demonstrate the issue. I consider this an extremely useful debug
> feature. If I command the memory to be read in units of 32 bits I
> really mean that. A "fix" ins print_buffer() whould hush up the
> symptoms, so the problem would be much harder to detect.

Thanks for the explanation, I didn't thought about it. This is
indeed a reasonable debug feature.

Best regards,
Anatolij

  reply	other threads:[~2010-06-29 13:34 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-21 20:29 [U-Boot] [PATCH] MPC5200: workaround data corruption for unaligned local bus accesses Wolfgang Denk
2010-06-22 23:10 ` [U-Boot] [PATCH v2] " Wolfgang Denk
2010-06-23  0:12 ` [U-Boot] [PATCH v3] " Wolfgang Denk
2010-06-25  8:35   ` Detlev Zundel
2010-06-29  9:48   ` [U-Boot] [PATCH] MPC512x: " Wolfgang Denk
2010-06-29 11:49     ` Detlev Zundel
2010-06-29 12:09       ` Wolfgang Denk
2010-06-29 12:41         ` Detlev Zundel
2010-06-29 12:42         ` Joakim Tjernlund
2010-06-29 12:55           ` Wolfgang Denk
2010-06-29 13:06             ` Joakim Tjernlund
2010-06-29 14:21               ` Joakim Tjernlund
2010-06-29 16:19             ` [U-Boot] [PATCH] MPC512x: workaround data corruption forunaligned " Steve Deiters
2010-06-29 19:24               ` Wolfgang Denk
2010-06-29 21:47                 ` Joakim Tjernlund
2010-06-29 12:23       ` [U-Boot] [PATCH] MPC512x: workaround data corruption for unaligned " Anatolij Gustschin
2010-06-29 12:47         ` Wolfgang Denk
2010-06-29 13:34           ` Anatolij Gustschin [this message]
2010-06-29 12:45     ` [U-Boot] [PATCH] Use memcpy in print_buffer to fix unaligned dumps Anatolij Gustschin
2010-06-29 12:53       ` Wolfgang Denk
2010-06-29 12:57         ` Wolfgang Denk
2010-06-29 19:42         ` Mike Frysinger
2010-06-29 19:29     ` [U-Boot] [PATCH] MPC512x: workaround data corruption for unaligned local bus accesses Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100629153406.653b6bc0@wker \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox