From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Tue, 29 Jun 2010 15:34:06 +0200 Subject: [U-Boot] [PATCH] MPC512x: workaround data corruption for unaligned local bus accesses In-Reply-To: <20100629124714.87A8314EBF8@gemini.denx.de> References: <1277251931-12994-1-git-send-email-wd@denx.de> <1277804892-453-1-git-send-email-wd@denx.de> <20100629142343.7ecadfaa@wker> <20100629124714.87A8314EBF8@gemini.denx.de> Message-ID: <20100629153406.653b6bc0@wker> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang, On Tue, 29 Jun 2010 14:47:14 +0200 Wolfgang Denk wrote: ... > > BTW, shouldn't we fix print_buffer() also? do_mem_md() doesn't use > > memcpy() and the issue with corrupted dumps still remains here. > > I'm testing a patch to fix it. Will submit it soon. > > I though about this, too. But then I decided against it. "md" is > intended to to exactly what the user requests - as is, we can easily > demonstrate the issue. I consider this an extremely useful debug > feature. If I command the memory to be read in units of 32 bits I > really mean that. A "fix" ins print_buffer() whould hush up the > symptoms, so the problem would be much harder to detect. Thanks for the explanation, I didn't thought about it. This is indeed a reasonable debug feature. Best regards, Anatolij