From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] smc911x_eeprom
Date: Tue, 29 Jun 2010 15:44:58 -0400 [thread overview]
Message-ID: <201006291544.59084.vapier@gentoo.org> (raw)
In-Reply-To: <AANLkTimpNA_OT4srHCa7DpLFESN5lRCnYEH_DgKW8TqH@mail.gmail.com>
On Tuesday, June 29, 2010 10:59:02 Sergey Alyoshin wrote:
> smc911x_eeprom: smc911x_detect_chip() function return 0 on success
this should be the subject, not the changelog
>
> diff --git a/examples/standalone/smc911x_eeprom.c
you're missing a signed-off-by tag which means your patch cannot be accepted
this ignores the fact that someone has already sent in a patch for this issue
and that has been added ;)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100629/da08116f/attachment.pgp
next prev parent reply other threads:[~2010-06-29 19:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 14:59 [U-Boot] [PATCH] smc911x_eeprom Sergey Alyoshin
2010-06-29 16:28 ` Ben Warren
2010-06-29 19:44 ` Mike Frysinger [this message]
2010-06-29 20:40 ` Sergey Alyoshin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006291544.59084.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox