From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 1 Jul 2010 05:33:46 +0200 Subject: [U-Boot] [PATCH] cmd_ide: Convert to [read,write][b,w] In-Reply-To: <4C2BE4D1.8090506@free.fr> References: <1277320683-2057-1-git-send-email-marek.vasut@gmail.com> <201007010209.32414.marek.vasut@gmail.com> <4C2BE4D1.8090506@free.fr> Message-ID: <201007010533.46927.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dne ?t 1. ?ervence 2010 02:44:01 Albert ARIBAUD napsal(a): > Le 01/07/2010 02:09, Marek Vasut a ?crit : > >>>> common/cmd_ide.c | 22 +++++++++++++--------- > >>>> 1 files changed, 13 insertions(+), 9 deletions(-) > >>> > >>> I don't see the big advantage of this patch yet. > >> > >> It won't compile at least on ARM. Same case as with the dm9000 ethernet > >> adapter. > >> > >>> What are the exact advantages of your version? > >> > >> That it actually compiles and works on other architectures than ppc. > > > > Any updates ? > > Actually I've compiled cmd_ide.c for ARM -- I just sent a patchset for > this. Required me to #define __io in my board's config, Are you really supposed to #define __io in your config ?! I doubt that. > and also to > #define CONFIG_IDE_SWAP_IO, a new configuration option which replaces > the complex conditionals on __PPC__ et al. > > Amicalement,