[U-Boot] [PATCH v2]ppc4xx/Canyonlands added USB board callbacks

[Stefan Roese <sr@denx.de>]

Hi Rup,

On Wednesday 07 July 2010 12:49:06 Rupjyoti Sarmah wrote:
> Functions added to support board callbacks for USB init. This
> isolates USB manipulations such that it is only touched if USB is
> used by U-Boot.

Thanks. Looks quite good now. Please find a small comment below.
 
<snip>

> diff --git a/include/configs/canyonlands.h b/include/configs/canyonlands.h
> index ac9b3c5..0eee522 100644
> --- a/include/configs/canyonlands.h
> +++ b/include/configs/canyonlands.h
> @@ -77,6 +77,18 @@
>  #define CONFIG_SYS_PCIE0_XCFGBASE	0xc3000000
>  #define CONFIG_SYS_PCIE1_XCFGBASE	0xc3001000
> 
> +/*
> + * BCSR bits as defined in the Canyonlands board user manual.
> + */
> +#define BCSR_CPLDREV		0x00
> +#define BCSR_BRDSTS		0x03
> +#define BCSR_FLASHCTRL		0x05
> +#define BCSR_ETHCTRL		0x06
> +#define BCSR_USBCTRL		0x07
> +#define BCSR_USBCTRL_OTG_RST	0x32
> +#define BCSR_USBCTRL_HOST_RST	0x01
> +#define CONFIG_SYS_BCSR3_PCIE	0x10
> +

Hmmm. Which of these defines are really bits and which are offsets for 
registers? You can remove the register offsets defines, since you're using the 
struct now. And please use consistent naming, and don't name one bit 
"CONFIG_SYS_BCSRxxx".

Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de