public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/85xx: Add command to report errata workarounds
Date: Wed, 14 Jul 2010 23:43:17 +0200	[thread overview]
Message-ID: <20100714214317.B26AC160696@gemini.denx.de> (raw)
In-Reply-To: <1279142410-30629-1-git-send-email-galak@kernel.crashing.org>

Dear Kumar Gala,

In message <1279142410-30629-1-git-send-email-galak@kernel.crashing.org> you wrote:
> Add 'errata' command to report what errata we workaround.  Report
> workaround for erratum SATA-A001 on P1022/P1013.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
...
> +#if defined(CONFIG_FSL_SATA_V2) && defined(CONFIG_FSL_SATA_ERRATUM_A001)
> +	if (IS_SVR_REV(svr, 1, 0)) {
> +		switch (SVR_SOC_VER(svr)) {
> +		case SVR_P1013:
> +		case SVR_P1013_E:
> +		case SVR_P1022:
> +		case SVR_P1022_E:
> +			puts("Work-around for Erratum SATA A001 enabled\n");
> +		}

I think there should be a "default" case?

> +++ b/include/configs/P1022DS.h
> @@ -345,6 +345,7 @@
>  #define CONFIG_CMD_ELF
>  #define CONFIG_CMD_IRQ
>  #define CONFIG_CMD_SETEXPR
> +#define CONFIG_CMD_ERRATA

Please sort the list.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I really hate this damned machine     It never does quite what I want
I wish that they would sell it.              But only what I tell it.

  reply	other threads:[~2010-07-14 21:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-10  4:18 [U-Boot] [PATCH 1/2] powerpc/85xx: Add command to report errata workarounds Kumar Gala
2010-06-10  4:18 ` [U-Boot] [PATCH 2/2] powerpc/85xx: Report workaround of errata SATA-A001 Kumar Gala
2010-06-11  1:58   ` Timur Tabi
2010-06-11 13:33     ` Kumar Gala
2010-06-30  9:40   ` Kumar Gala
2010-07-14 19:30   ` Wolfgang Denk
2010-07-14 21:06     ` Kumar Gala
2010-07-14 21:13       ` Wolfgang Denk
2010-07-14 21:20       ` [U-Boot] [PATCH] powerpc/85xx: Add command to report errata workarounds Kumar Gala
2010-07-14 21:43         ` Wolfgang Denk [this message]
2010-07-14 22:05           ` Kumar Gala
2010-07-14 22:07       ` [U-Boot] [PATCH v3] " Kumar Gala
2010-06-30  9:39 ` [U-Boot] [PATCH 1/2] " Kumar Gala
2010-07-14 19:29 ` Wolfgang Denk
2010-07-14 20:50   ` Kumar Gala
2010-07-14 21:00     ` Wolfgang Denk
2010-07-14 21:06       ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100714214317.B26AC160696@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox