From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common: add a grepenv command
Date: Fri, 16 Jul 2010 13:42:52 -0500 [thread overview]
Message-ID: <20100716134252.b053e2dc.kim.phillips@freescale.com> (raw)
In-Reply-To: <20100716092703.02D6D153A82@gemini.denx.de>
On Fri, 16 Jul 2010 11:27:03 +0200
Wolfgang Denk <wd@denx.de> wrote:
> Dear Kim Phillips,
>
> In message <20100715221522.1dd4eecb.kim.phillips@freescale.com> you wrote:
> > u-boot environments, esp. when boards are shared across multiple users,
> > can get pretty large and time consuming to visually parse.
> > The grepenv command this patch adds can be used in lieu of printenv
> > to facilitate searching. grepenv works like printenv but limits its output
> > only to environment strings (variable name and value pairs) that match the
> > user specified substring.
>
> Thanks, but I will not apply thjis.
>
> I'm in the process of resturcturing the whole environment handling.
> The new implementation will use a hash table for internal storage, so
> this code would no longer apply then.
it would still apply, in that the environment should still be greppable,
but, yes, if the internal structures are changed, this patch would need
updating, along the same lines as with printenv and friends.
> Please wait a bit for me to publish the new code, and then try to
> reimplement it in the new environment.
technically this should be allowed in, because it was submitted first
and it's need is overdue IMHO (I have already gotten off-list thanks
for this patch). Subsequent patches need to honour valid patches
posted to the list first.
Having said that, would you like to send me your hash table patches?
Kim
next prev parent reply other threads:[~2010-07-16 18:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 3:15 [U-Boot] [PATCH] common: add a grepenv command Kim Phillips
2010-07-16 9:27 ` Wolfgang Denk
2010-07-16 10:29 ` Reinhard Meyer
2010-07-16 10:55 ` Wolfgang Denk
2010-07-16 19:02 ` Kim Phillips
2010-07-16 19:13 ` Wolfgang Denk
2010-07-16 18:42 ` Kim Phillips [this message]
2010-07-16 19:12 ` Wolfgang Denk
2010-07-16 20:41 ` Scott Wood
2010-07-18 3:32 ` Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100716134252.b053e2dc.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox