From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/5] New environment code
Date: Sat, 17 Jul 2010 23:55:36 +0200 [thread overview]
Message-ID: <20100717215536.7F1D2153A7F@gemini.denx.de> (raw)
In-Reply-To: <1279395948-25864-1-git-send-email-wd@denx.de>
In message <1279395948-25864-1-git-send-email-wd@denx.de> I wrote:
>
> The following patch series adds some utilities (qsort and hash table
> based database functions) and uses these to reimplement the code used
> for the internal handling of environment variables.
>
>
> Motivation:
>
> * Old environment code used a pessimizing implementation:
> - variable lookup used linear search => slow
> - changed/added variables were added at the end, i. e. most
> frequently used variables had the slowest access times => slow
> - each setenv() would calculate the CRC32 checksum over the whole
> environment block => slow
Just to give a datapoint for speed:
measured on TQM5200 (MPC5200 at 400 MHz, environment size 16 kB):
OLD implementation:
=> sete ttt 'date;for i in 0 1 2 3 4 5 6 7 8 9 ; do for j in 0 1 2 3 4 5 6 7 8 9 ; do for k in 0 1 2 3 4 5 6 7 8 9 ; do run tt ; done ; done ; done;date'
=> sete tt 'sete var1 xxx;sete var2 ${var1};sete var1 ${var2};sete var1;sete var2'
=> run tt
=> run ttt
Date: 1910-07-17 (unknown day) Time: 22:02:31
Date: 1910-07-17 (unknown day) Time: 22:03:27
New implementation:
=> run ttt
Date: 1910-07-17 (unknown day) Time: 20:45:51
Date: 1910-07-17 (unknown day) Time: 20:45:53
I. e. we have 56 versus 2 seconds.
I haven't run intensive tests, but in general I think we can see that
scripts referncing environment variables will typically run faster by
a factor of 10, or more.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Time is an illusion perpetrated by the manufacturers of space.
next prev parent reply other threads:[~2010-07-17 21:55 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-17 19:45 [U-Boot] [PATCH 0/5] New environment code Wolfgang Denk
2010-07-17 19:45 ` [U-Boot] [PATCH 1/5] Add basic errno support Wolfgang Denk
2010-07-17 21:17 ` Mike Frysinger
2010-07-17 21:34 ` Wolfgang Denk
2010-07-18 12:51 ` Jerry Van Baren
2010-07-18 13:03 ` Wolfgang Denk
2010-09-12 19:16 ` Wolfgang Denk
2010-07-17 19:45 ` [U-Boot] [PATCH 2/5] Add qsort - add support for sorting data arrays Wolfgang Denk
2010-09-12 19:16 ` Wolfgang Denk
2010-07-17 19:45 ` [U-Boot] [PATCH 3/5] Add hash table support as base for new environment code Wolfgang Denk
2010-09-12 19:16 ` Wolfgang Denk
2010-12-08 9:44 ` Mike Frysinger
2010-12-08 10:02 ` Wolfgang Denk
2010-12-08 10:52 ` Mike Frysinger
2010-07-17 19:45 ` [U-Boot] [PATCH 4/5] Remove support for CONFIG_HAS_UID and "forceenv" command Wolfgang Denk
2010-07-17 22:12 ` Sergey Kubushyn
2010-09-12 19:18 ` Wolfgang Denk
2010-07-17 19:45 ` [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables Wolfgang Denk
2010-07-17 22:48 ` [U-Boot] [PATCH] new env: fix off-by-one error in setenv command Wolfgang Denk
2010-07-20 0:38 ` [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables Kim Phillips
2010-07-20 9:40 ` Wolfgang Denk
2010-07-20 18:36 ` Kim Phillips
2010-07-20 19:01 ` Wolfgang Denk
2010-07-20 20:09 ` Wolfgang Denk
[not found] ` <1279658019.5685.125.camel@thunk>
2010-07-20 20:35 ` Wolfgang Denk
2010-07-20 21:08 ` Kim Phillips
2010-07-20 21:43 ` Wolfgang Denk
2010-07-20 22:00 ` Kim Phillips
2010-07-25 21:45 ` Wolfgang Denk
2010-07-26 23:18 ` Kim Phillips
2010-07-20 19:11 ` Wolfgang Denk
2010-07-26 14:52 ` Matthias Fuchs
2010-07-28 21:17 ` Wolfgang Denk
2010-07-29 9:16 ` Matthias Fuchs
2010-08-03 22:48 ` Wolfgang Denk
2010-09-12 19:19 ` Wolfgang Denk
2010-12-30 1:53 ` [U-Boot] env_flash.c:saveenv() broken when env is smaller than a sector Mike Frysinger
2010-12-30 2:39 ` Mike Frysinger
2011-01-17 20:23 ` Wolfgang Denk
2010-07-17 19:49 ` [U-Boot] [PATCH 0/5] New environment code Wolfgang Denk
2010-07-17 20:56 ` Reinhard Meyer
2010-07-17 21:28 ` Mike Frysinger
2010-07-17 21:41 ` Wolfgang Denk
2010-07-18 2:18 ` Mike Frysinger
2010-07-17 21:31 ` Wolfgang Denk
2010-07-17 21:55 ` Wolfgang Denk [this message]
2010-07-18 5:32 ` Reinhard Meyer
2010-07-18 10:26 ` Wolfgang Denk
2010-10-20 8:08 ` Mike Frysinger
2010-10-20 8:19 ` Wolfgang Denk
2010-12-08 9:56 ` Mike Frysinger
2010-12-08 10:04 ` Wolfgang Denk
2010-12-08 10:19 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100717215536.7F1D2153A7F@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox