public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] net, fec: fix "Warning: eth device name has a space!" for FEC devices
Date: Tue, 20 Jul 2010 00:57:11 +0200	[thread overview]
Message-ID: <20100719225711.20B4E14EB09@gemini.denx.de> (raw)
In-Reply-To: <4C44C8F9.6020904@denx.de>

Dear Heiko Schocher,

In message <4C44C8F9.6020904@denx.de> you wrote:
> since commit 1384f3bb8a4f9066805b70c1418eda78ecb73fdd ethernet names
> with spaces drop a
> 
> Warning: eth device name has a space!
> 
> message. This patch fix it for:
> 
> - "FEC ETHERNET" devices found on
>   mpc512x, mpc5xxx, mpc8xx and mpc8220 boards.
>   renamed to "FEC".
> - "SCC ETHERNET" devices found on
>   mpc8xx, mpc82xx based boards. Renamed to "SCC".
> - "HDLC ETHERNET" devices found on mpc8xx boards
>   Renamed to "HDLC"
> - "FCC ETHERNET" devices found on mpc8260 and mpc85xx based
>   boards. Renamed to "FCC"

The Subject: (which is way too long, btw.) does not match the content
of this patch.


I'm not sure if it is a good idea to change the board specific
README's. For example, board/LEOX/elpt860/README.LEOX shows

	U-Boot 0.2.2 ...
	...
	Net:   SCC ETHERNET

For this specific version, the string was correct. Changing it is
technically not correct.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The goal of science is to build better mousetraps. The goal of nature
is to build better mice.

  reply	other threads:[~2010-07-19 22:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-19 21:51 [U-Boot] [PATCH v2] net, fec: fix "Warning: eth device name has a space!" for FEC devices Heiko Schocher
2010-07-19 22:57 ` Wolfgang Denk [this message]
2010-07-19 23:02   ` Ben Warren
2010-07-20 15:45   ` [U-Boot] [PATCH v3] net ppc: fix ethernet device names with spaces Heiko Schocher
2010-07-20 21:46     ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100719225711.20B4E14EB09@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox