From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 20 Jul 2010 07:01:47 +0200
Subject: [U-Boot] [PATCH] ppc4xx: Add CONFIG_DDR_RFDC_FIXED to allow
	board specific RFDC values
In-Reply-To: <20100719175408.AA138153A81@gemini.denx.de>
References: <1279542253-27041-1-git-send-email-sr@denx.de>
	<20100719175408.AA138153A81@gemini.denx.de>
Message-ID: <201007200701.47949.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On Monday 19 July 2010 19:54:08 Wolfgang Denk wrote:
> > @@ -767,6 +767,13 @@ static u32 DQS_calibration_methodB(struct ddrautocal
> > *cal)
> > 
> >  	debug("\n\n");
> > 
> > +#if defined(CONFIG_DDR_RFDC_FIXED)
> > +	mtsdram(SDRAM_RFDC, CONFIG_DDR_RFDC_FIXED);
> > +	size = 512;
> > +	rffd_average = CONFIG_DDR_RFDC_FIXED & SDRAM_RFDC_RFFD_MASK;
> > +	mfsdram(SDRAM_RDCC, rdcc);	/* record this value */
> > +	cal->rdcc = rdcc;
> > +#else
> > 
> >  	in_window = 0;
> >  	rdcc = 0;
> > 
> > @@ -830,6 +837,7 @@ static u32 DQS_calibration_methodB(struct ddrautocal
> > *cal)
> > 
> >  		rffd_average = SDRAM_RFDC_RFFD_MAX;
> >  	
> >  	mtsdram(SDRAM_RFDC, rfdc_reg | SDRAM_RFDC_RFFD_ENCODE(rffd_average));
> > 
> > +#endif
> 
> In cases of such long blocks, where the ending #endif is many, many
> lines away, it is usually helpful to mark where the #endif belongs to:
> 
> 	#endif /* CONFIG_DDR_RFDC_FIXED */
> 
> Please do this here, too.

Yes, good idea. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de