From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Sat, 31 Jul 2010 19:16:58 +0200
Subject: [U-Boot] [PATCH] board/purple/flash.c: removed unneded test
In-Reply-To: <1280585375-1613-1-git-send-email-fransmeulenbroeks@gmail.com>
References: <1280585375-1613-1-git-send-email-fransmeulenbroeks@gmail.com>
Message-ID: <20100731171658.BD3C6152398@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Frans Meulenbroeks,

In message <1280585375-1613-1-git-send-email-fransmeulenbroeks@gmail.com> you wrote:
> removed part of a test which tested for a var that did not change
> within the loop and hence was superfluous

Hm... if you check the code, you see that the other "references" to
this variable are not exactly making much sense either. And the
function does not return any useful error codes.

Looks as if this never was really thought to an end...

If you touch this file, we should throw out rcode completely.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In accord with UNIX philosophy, Perl gives you enough  rope  to  hang
yourself.              - L. Wall & R. L. Schwartz, _Programming Perl_