From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Tue, 3 Aug 2010 13:59:35 -0400 Subject: [U-Boot] [PATCH] Adds driver for Xilinx' xps_spi SPI controller. In-Reply-To: <1280850462-26098-1-git-send-email-graeme.smecher@mail.mcgill.ca> References: <1280850462-26098-1-git-send-email-graeme.smecher@mail.mcgill.ca> Message-ID: <201008031359.36294.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, August 03, 2010 11:47:42 Graeme Smecher wrote: > --- a/drivers/spi/Makefile > +++ b/drivers/spi/Makefile > > COBJS-$(CONFIG_ALTERA_SPI) += altera_spi.o > +COBJS-$(CONFIG_XILINX_SPI) += xilinx_spi.o > COBJS-$(CONFIG_ATMEL_DATAFLASH_SPI) += atmel_dataflash_spi.o this is a sorted list. please keep it that way > --- /dev/null > +++ b/drivers/spi/xilinx_spi.c > > +static ulong xilinx_spi_base_list[] = { > +#ifdef XPAR_SPI_0_BASEADDR > + XPAR_SPI_0_BASEADDR, > +#endif > +#ifdef XPAR_SPI_1_BASEADDR > + XPAR_SPI_1_BASEADDR, > +#endif > +#ifdef XPAR_SPI_2_BASEADDR > + XPAR_SPI_2_BASEADDR, > +#endif > +#ifdef XPAR_SPI_3_BASEADDR > + XPAR_SPI_3_BASEADDR, > +#endif > +}; if this is only ever read, you might want to declare it const so it ends up in the rodata section. what if someone defines just XPAR_SPI_3_BASEADDR ? do you want to be consistent in bus id 3 always corresponds to XPAR_SPI_3_BASEADDR ? or are you OK with the numbers always being relative ? doesnt matter to me, just highlighting some things that might have been missed. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20100803/1987da11/attachment.pgp