From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/7] PXA: Add initial Palm LifeDrive support
Date: Tue, 03 Aug 2010 23:13:42 +0200 [thread overview]
Message-ID: <20100803211342.EC6BC28F@gemini.denx.de> (raw)
In-Reply-To: <1279811005-21858-6-git-send-email-marek.vasut@gmail.com>
Dear Marek Vasut,
In message <1279811005-21858-6-git-send-email-marek.vasut@gmail.com> you wrote:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
> board/palmld/Makefile | 54 ++++++++
> board/palmld/config.mk | 1 +
> board/palmld/lowlevel_init.S | 46 +++++++
> board/palmld/palmld.c | 81 ++++++++++++
> board/palmld/u-boot.lds | 56 +++++++++
> boards.cfg | 1 +
> include/configs/palmld.h | 275 ++++++++++++++++++++++++++++++++++++++++++
> 7 files changed, 514 insertions(+), 0 deletions(-)
> create mode 100644 board/palmld/Makefile
> create mode 100644 board/palmld/config.mk
> create mode 100644 board/palmld/lowlevel_init.S
> create mode 100644 board/palmld/palmld.c
> create mode 100644 board/palmld/u-boot.lds
> create mode 100644 include/configs/palmld.h
Entries to MAINTAINERS and MAKEALL missing.
> diff --git a/board/palmld/Makefile b/board/palmld/Makefile
> new file mode 100644
> index 0000000..c184cf6
> --- /dev/null
> +++ b/board/palmld/Makefile
> @@ -0,0 +1,54 @@
> +
> +#
Don't waste too many empty lines.
> +# Copyright (C) 2009
2009?
[Please see comments for previous patch; seems this one looks pretty
much similar.]
Actually the code looks pretty much similar, too.
Are you sure that multiple copies of htis code are needed?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We want to create puppets that pull their own strings. - Ann Marion
next prev parent reply other threads:[~2010-08-03 21:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 15:03 [U-Boot] [PATCH 1/7] ARM: Define __raw_readX and __raw_writeX Marek Vasut
2010-07-22 15:03 ` [U-Boot] [PATCH 2/7] PXA: pxafb: Add ACX517AKN support Marek Vasut
2010-07-22 15:03 ` [U-Boot] [PATCH 3/7] common: Enable serial for PXA250 Marek Vasut
2010-07-22 15:03 ` [U-Boot] [PATCH 4/7] PXA: Palm Tungsten|C Support Marek Vasut
2010-08-03 21:10 ` Wolfgang Denk
2010-07-22 15:03 ` [U-Boot] [PATCH 5/7] PXA: pxafb: Add support for Sharp LQ038J7DH53 Marek Vasut
2010-07-22 15:03 ` [U-Boot] [PATCH 6/7] PXA: Add initial Palm LifeDrive support Marek Vasut
2010-08-03 21:13 ` Wolfgang Denk [this message]
2010-07-22 15:03 ` [U-Boot] [PATCH 7/7] PXA: Vpac270 config fixes Marek Vasut
2010-08-03 21:16 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100803211342.EC6BC28F@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox