public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/7] PXA: Vpac270 config fixes
Date: Tue, 03 Aug 2010 23:16:17 +0200	[thread overview]
Message-ID: <20100803211617.1C86D28F@gemini.denx.de> (raw)
In-Reply-To: <1279811005-21858-7-git-send-email-marek.vasut@gmail.com>

Dear Marek Vasut,

In message <1279811005-21858-7-git-send-email-marek.vasut@gmail.com> you wrote:
> Define __io to get harddrive working.
> Fix saving of environment into OneNAND.
> Boot from harddrive when possible.
> 
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
>  include/configs/vpac270.h |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/vpac270.h b/include/configs/vpac270.h
> index 6d02995..a0383b2 100644
> --- a/include/configs/vpac270.h
> +++ b/include/configs/vpac270.h
> @@ -36,7 +36,7 @@
>  /*
>   * Environment settings
>   */
> -#define	CONFIG_ENV_SIZE			0x4000
> +#define	CONFIG_ENV_SIZE			0x20000


Do you really need 128 KiB for environment data? [Note that this is
NOT a sector size or so!]

Really???  I think this is not true.

> +/*
> + * HACK WARNING: __io
> + * This MUST go away once the readb/writeb and inb/outb issue is solved
> + */
> +#define __io

Drop that.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Plan to throw one away. You will anyway."
                              - Fred Brooks, "The Mythical Man Month"

      reply	other threads:[~2010-08-03 21:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-22 15:03 [U-Boot] [PATCH 1/7] ARM: Define __raw_readX and __raw_writeX Marek Vasut
2010-07-22 15:03 ` [U-Boot] [PATCH 2/7] PXA: pxafb: Add ACX517AKN support Marek Vasut
2010-07-22 15:03 ` [U-Boot] [PATCH 3/7] common: Enable serial for PXA250 Marek Vasut
2010-07-22 15:03 ` [U-Boot] [PATCH 4/7] PXA: Palm Tungsten|C Support Marek Vasut
2010-08-03 21:10   ` Wolfgang Denk
2010-07-22 15:03 ` [U-Boot] [PATCH 5/7] PXA: pxafb: Add support for Sharp LQ038J7DH53 Marek Vasut
2010-07-22 15:03 ` [U-Boot] [PATCH 6/7] PXA: Add initial Palm LifeDrive support Marek Vasut
2010-08-03 21:13   ` Wolfgang Denk
2010-07-22 15:03 ` [U-Boot] [PATCH 7/7] PXA: Vpac270 config fixes Marek Vasut
2010-08-03 21:16   ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100803211617.1C86D28F@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox