From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 04 Aug 2010 00:33:49 +0200 Subject: [U-Boot] [PATCH 1/2] S5P: support mmc driver In-Reply-To: <4C331C61.9070400@samsung.com> References: <4C331C61.9070400@samsung.com> Message-ID: <20100803223349.B10E428F@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Minkyu Kang, In message <4C331C61.9070400@samsung.com> you wrote: > This patch adds support mmc driver for s5p SoC ... > +#ifdef DEBUG_S5P_HSMMC > +#define dbg(x...) printf(x) > +#else > +#define dbg(x...) do { } while (0) > +#endif Can you please rework this code to use the standard debug() macro instead of your own? Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "...all the good computer designs are bootlegged; the formally planned products, if they are built at all, are dogs!" - David E. Lundstrom, "A Few Good Men From Univac", MIT Press, 1987