From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/9] PXA: Balloon3 board support
Date: Tue, 10 Aug 2010 23:52:07 +0200 [thread overview]
Message-ID: <20100810215207.358641536EF@gemini.denx.de> (raw)
In-Reply-To: <1281415810-31363-8-git-send-email-marek.vasut@gmail.com>
Dear Marek Vasut,
In message <1281415810-31363-8-git-send-email-marek.vasut@gmail.com> you wrote:
> The following hardware is currently supported:
> - UART
> - USB Host
> - FPGA
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
> MAKEALL | 1 +
> board/balloon3/Makefile | 49 +++++++
> board/balloon3/balloon3.c | 227 +++++++++++++++++++++++++++++++++
> board/balloon3/config.mk | 1 +
> board/balloon3/lowlevel_init.S | 36 ++++++
> board/balloon3/u-boot.lds | 55 ++++++++
> boards.cfg | 1 +
> include/configs/balloon3.h | 270 ++++++++++++++++++++++++++++++++++++++++
> 8 files changed, 640 insertions(+), 0 deletions(-)
> create mode 100644 board/balloon3/Makefile
> create mode 100644 board/balloon3/balloon3.c
> create mode 100644 board/balloon3/config.mk
> create mode 100644 board/balloon3/lowlevel_init.S
> create mode 100644 board/balloon3/u-boot.lds
> create mode 100644 include/configs/balloon3.h
MAINTAINERS entry missing.
...
> +int board_init (void)
> +{
> + /* memory and cpu-speed are setup before relocation */
> + /* so we do _nothing_ here */
Nothing? This comment is wrong.
> + /* arch number of vpac270 */
> + gd->bd->bi_arch_number = MACH_TYPE_BALLOON3;
> +
> + /* adress of boot parameters */
> + gd->bd->bi_boot_params = 0xa0000100;
> +
> + /* Init the FPGA */
> + balloon3_init_fpga();
This is definitely more than nothing.
> + UHCHR = (UHCHR | UHCHR_PCPL | UHCHR_PSPL) &
> + ~(UHCHR_SSEP0 | UHCHR_SSEP1 | UHCHR_SSEP2 | UHCHR_SSE);
> +
> + UHCHR |= UHCHR_FSBIR;
Please use I/O accessors to access device registers. Please fix
globally.
> + while (UHCHR & UHCHR_FSBIR);
The semicolon goes to the next line.
> +#ifdef CONFIG_CMD_KGDB
> +#define CONFIG_KGDB_BAUDRATE 230400 /* speed to run kgdb serial port */
Line too long. Please fix globally.
I stop reviewing here. Please check the other patches for similar
issues, and fix these as well. Please also re-read the review
comments for the first patch series.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I am not now, nor have I ever been, a member of the demigodic party.
-- Dennis Ritchie
next prev parent reply other threads:[~2010-08-10 21:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 4:50 [U-Boot] [PATCH 1/9] ARM: Define __raw_readX and __raw_writeX Marek Vasut
2010-08-10 4:50 ` [U-Boot] [PATCH 2/9] PXA: pxafb: Add ACX517AKN support Marek Vasut
2010-08-10 21:45 ` Wolfgang Denk
2010-08-10 23:56 ` Marek Vasut
2010-08-20 9:31 ` [U-Boot] [PATCH 1/8] " Marek Vasut
2010-08-20 9:31 ` [U-Boot] [PATCH 2/8] common: Enable serial for PXA250 Marek Vasut
2010-08-20 9:31 ` [U-Boot] [PATCH 3/8 v2] PXA: Palm Tungsten|C Support Marek Vasut
2010-08-20 9:31 ` [U-Boot] [PATCH 4/8] PXA: pxafb: Add support for Sharp LQ038J7DH53 Marek Vasut
2010-08-20 9:31 ` [U-Boot] [PATCH 5/8] PXA: Add initial Palm LifeDrive support Marek Vasut
2010-08-20 9:31 ` [U-Boot] [PATCH 6/8] PXA: Voipac270 improvements Marek Vasut
2010-09-07 21:13 ` Wolfgang Denk
2010-09-07 21:30 ` Marek Vasut
2010-09-07 22:34 ` Marek Vasut
2010-08-20 9:31 ` [U-Boot] [PATCH 7/8] PXA: Balloon3 board support Marek Vasut
2010-09-07 21:17 ` Wolfgang Denk
2010-09-07 21:27 ` Marek Vasut
2010-08-20 9:31 ` [U-Boot] [PATCH 8/8] PXA: Add missing MAINTAINERS entries Marek Vasut
2010-08-10 4:50 ` [U-Boot] [PATCH 3/9] common: Enable serial for PXA250 Marek Vasut
2010-08-10 4:50 ` [U-Boot] [PATCH 4/9] PXA: Palm Tungsten|C Support Marek Vasut
2010-08-10 4:50 ` [U-Boot] [PATCH 5/9] PXA: pxafb: Add support for Sharp LQ038J7DH53 Marek Vasut
2010-08-10 4:50 ` [U-Boot] [PATCH 6/9] PXA: Add initial Palm LifeDrive support Marek Vasut
2010-08-10 4:50 ` [U-Boot] [PATCH 7/9] PXA: Voipac270 improvements Marek Vasut
2010-08-10 4:50 ` [U-Boot] [PATCH 8/9] PXA: Balloon3 board support Marek Vasut
2010-08-10 21:52 ` Wolfgang Denk [this message]
2010-08-10 4:50 ` [U-Boot] [PATCH 9/9] PXA: Add missing MAINTAINERS entries Marek Vasut
2010-08-10 21:48 ` Wolfgang Denk
2010-08-10 21:38 ` [U-Boot] [PATCH 1/9] ARM: Define __raw_readX and __raw_writeX Wolfgang Denk
2010-08-10 23:52 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100810215207.358641536EF@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox