* [U-Boot] [PATCH] cfi_flash: flinfo: allow user interrupt in flash print info fn
@ 2010-07-26 23:35 Kim Phillips
2010-08-12 12:00 ` Stefan Roese
2010-08-12 21:02 ` Wolfgang Denk
0 siblings, 2 replies; 3+ messages in thread
From: Kim Phillips @ 2010-07-26 23:35 UTC (permalink / raw)
To: u-boot
flashes getting larger, users more impatient.
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
drivers/mtd/cfi_flash.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index 3267c5d..38d0ca5 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -1159,6 +1159,8 @@ void flash_print_info (flash_info_t * info)
puts ("\n Sector Start Addresses:");
for (i = 0; i < info->sector_count; ++i) {
+ if (ctrlc())
+ return;
if ((i % 5) == 0)
printf ("\n");
#ifdef CONFIG_SYS_FLASH_EMPTY_INFO
--
1.7.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] cfi_flash: flinfo: allow user interrupt in flash print info fn
2010-07-26 23:35 [U-Boot] [PATCH] cfi_flash: flinfo: allow user interrupt in flash print info fn Kim Phillips
@ 2010-08-12 12:00 ` Stefan Roese
2010-08-12 21:02 ` Wolfgang Denk
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2010-08-12 12:00 UTC (permalink / raw)
To: u-boot
On Tuesday 27 July 2010 01:35:39 Kim Phillips wrote:
> flashes getting larger, users more impatient.
Applied to u-boot-cfi-flash/master. Thanks.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] cfi_flash: flinfo: allow user interrupt in flash print info fn
2010-07-26 23:35 [U-Boot] [PATCH] cfi_flash: flinfo: allow user interrupt in flash print info fn Kim Phillips
2010-08-12 12:00 ` Stefan Roese
@ 2010-08-12 21:02 ` Wolfgang Denk
1 sibling, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2010-08-12 21:02 UTC (permalink / raw)
To: u-boot
Dear Kim Phillips,
In message <20100726183539.1732824f.kim.phillips@freescale.com> you wrote:
> flashes getting larger, users more impatient.
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> drivers/mtd/cfi_flash.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
> index 3267c5d..38d0ca5 100644
> --- a/drivers/mtd/cfi_flash.c
> +++ b/drivers/mtd/cfi_flash.c
> @@ -1159,6 +1159,8 @@ void flash_print_info (flash_info_t * info)
>
> puts ("\n Sector Start Addresses:");
> for (i = 0; i < info->sector_count; ++i) {
> + if (ctrlc())
> + return;
> if ((i % 5) == 0)
> printf ("\n");
> #ifdef CONFIG_SYS_FLASH_EMPTY_INFO
NAK. This code (and the existing "if ((i % 5) == 0) printf ("\n");" as
well) is incorrectly placed, i. e. before variable declarations.
Please fix.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
HEALTH WARNING: Care Should Be Taken When Lifting This Product, Since
Its Mass, and Thus Its Weight, Is Dependent on Its Velocity Relative
to the User.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-12 21:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-26 23:35 [U-Boot] [PATCH] cfi_flash: flinfo: allow user interrupt in flash print info fn Kim Phillips
2010-08-12 12:00 ` Stefan Roese
2010-08-12 21:02 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox