From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cfi_flash: flinfo: allow user interrupt in flash print info fn
Date: Thu, 12 Aug 2010 23:02:32 +0200 [thread overview]
Message-ID: <20100812210232.0684F154736@gemini.denx.de> (raw)
In-Reply-To: <20100726183539.1732824f.kim.phillips@freescale.com>
Dear Kim Phillips,
In message <20100726183539.1732824f.kim.phillips@freescale.com> you wrote:
> flashes getting larger, users more impatient.
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> drivers/mtd/cfi_flash.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
> index 3267c5d..38d0ca5 100644
> --- a/drivers/mtd/cfi_flash.c
> +++ b/drivers/mtd/cfi_flash.c
> @@ -1159,6 +1159,8 @@ void flash_print_info (flash_info_t * info)
>
> puts ("\n Sector Start Addresses:");
> for (i = 0; i < info->sector_count; ++i) {
> + if (ctrlc())
> + return;
> if ((i % 5) == 0)
> printf ("\n");
> #ifdef CONFIG_SYS_FLASH_EMPTY_INFO
NAK. This code (and the existing "if ((i % 5) == 0) printf ("\n");" as
well) is incorrectly placed, i. e. before variable declarations.
Please fix.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
HEALTH WARNING: Care Should Be Taken When Lifting This Product, Since
Its Mass, and Thus Its Weight, Is Dependent on Its Velocity Relative
to the User.
prev parent reply other threads:[~2010-08-12 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 23:35 [U-Boot] [PATCH] cfi_flash: flinfo: allow user interrupt in flash print info fn Kim Phillips
2010-08-12 12:00 ` Stefan Roese
2010-08-12 21:02 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100812210232.0684F154736@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox