From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] I2C: Add support for multiple I2C busses for SNTP (effect to RTC)
Date: Fri, 20 Aug 2010 16:05:15 +0200 [thread overview]
Message-ID: <20100820140515.376CC1557E4@gemini.denx.de> (raw)
In-Reply-To: <1282310377-9302-1-git-send-email-linz@li-pro.net>
Dear Stephan Linz,
In message <1282310377-9302-1-git-send-email-linz@li-pro.net> you wrote:
> This patch switches to the desired I2C bus when the SNTP
> network service is called. This can be configured using the
> CONFIG_SYS_RTC_BUS_NUM define.
...
> +#if defined(CONFIG_CMD_DATE)
> +/* FIXME: The i2c dependency should move into the RTC drivers itself. This higher
> + * network layer must not know about hardware specifics!!!!!!! */
Incorrect multiline comment style. And line too long.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Extreme feminine beauty is always disturbing.
-- Spock, "The Cloud Minders", stardate 5818.4
next prev parent reply other threads:[~2010-08-20 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 13:19 [U-Boot] [PATCH] I2C: Add support for multiple I2C busses for SNTP (effect to RTC) Stephan Linz
2010-08-20 14:05 ` Wolfgang Denk [this message]
2010-08-20 15:54 ` Stephan Linz
2010-08-23 6:43 ` Heiko Schocher
-- strict thread matches above, loose matches on Subject: below --
2010-08-23 7:29 Stephan Linz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820140515.376CC1557E4@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox