From: David Jander <david.jander@protonic.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Use common function to set GPIOs for MX3 and MX5
Date: Mon, 23 Aug 2010 11:14:40 +0200 [thread overview]
Message-ID: <201008231114.40225.david.jander@protonic.nl> (raw)
In-Reply-To: <201008231050.53956.david.jander@protonic.nl>
On Monday 23 August 2010 10:50:53 am David Jander wrote:
> I am just now picking up where I left last week, so give me a few hours and
> I should have something working, I guess.
Ok, I guess I was pessimistic. There is a weird bug in mxc_spi.c: CPOL is
negated!
I just saw that in the mx51evk.h header file CONFIG_FSL_PMIC_MODE was set to
low-active clock (CPOL=1), which is not supposed to work. But it did work, and
on the scope clock-polarity was active-high.
In spi_cfg(), I saw this line:
if (!(mode & SPI_CPOL))
sclkpol = 1;
AFAIK, this should be:
if (mode & SPI_CPOL)
sclkpol = 1;
At least for the MX51. Can you confirm that this is different on the MX31?
Now I get a correct flash id.
Best regards,
--
David Jander
Protonic Holland.
next prev parent reply other threads:[~2010-08-23 9:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 8:20 [U-Boot] [PATCH] Use common function to set GPIOs for MX3 and MX5 Stefano Babic
2010-08-20 8:46 ` David Jander
2010-08-20 9:29 ` David Jander
2010-08-20 10:01 ` Stefano Babic
2010-08-20 10:07 ` David Jander
2010-08-20 10:20 ` Stefano Babic
2010-08-20 10:30 ` David Jander
2010-08-20 11:19 ` Stefano Babic
2010-08-20 12:15 ` David Jander
2010-08-20 13:35 ` Stefano Babic
2010-08-23 8:50 ` David Jander
2010-08-23 9:14 ` David Jander [this message]
2010-08-23 10:37 ` Stefano Babic
2010-08-23 11:30 ` David Jander
2010-08-23 15:55 ` Stefano Babic
2010-08-23 17:18 ` Stefan Roese
2010-08-23 21:03 ` Detlev Zundel
2010-08-23 21:53 ` Mike Frysinger
2010-08-26 9:09 ` Detlev Zundel
2010-08-23 10:28 ` Stefano Babic
2010-08-20 10:55 ` [U-Boot] [PATCH V2] " Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008231114.40225.david.jander@protonic.nl \
--to=david.jander@protonic.nl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox