From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] SPI: cmd_spi.c: add option to specify bus and mode
Date: Wed, 25 Aug 2010 22:04:11 -0400 [thread overview]
Message-ID: <201008252204.12504.vapier@gentoo.org> (raw)
In-Reply-To: <4C73A4BD.506@emk-elektronik.de>
On Tuesday, August 24, 2010 06:53:49 Reinhard Meyer wrote:
> > this usage string no longer makes sense. how about:
> > "[<bus>:]<cs>[.<mode>] <bit_len> <dout> - Send <bit_len> bits from
> > <dout> out the SPI\n"
>
> The problem is, that without blowing up the parser even more, only
> 2 forms of the command are valid:
>
> the classic form
>
> <cs> <bit_len> <dout>
>
> or
>
> <bus>:<cs>[.<mode>] <bit_len> <dout>
how so ? the bus:cs.mode field is always going to be one argv, and your patch
has it so that argv[1] is always parsed against this form. i dont see where
this limitation is that you're seeing ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100825/0c095ac0/attachment.pgp
next prev parent reply other threads:[~2010-08-26 2:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 16:21 [U-Boot] [PATCH] SPI: cmd_spi.c: add option to specify bus and mode Reinhard Meyer
2010-08-09 17:05 ` Mike Frysinger
2010-08-23 22:15 ` Mike Frysinger
2010-08-24 8:05 ` Reinhard Meyer
2010-08-24 21:07 ` Mike Frysinger
2010-08-24 10:53 ` Reinhard Meyer
2010-08-26 2:04 ` Mike Frysinger [this message]
2010-08-26 5:26 ` Reinhard Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008252204.12504.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox