From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Disaligned buffer in print_buffer
Date: Fri, 27 Aug 2010 14:12:46 -0400 [thread overview]
Message-ID: <201008271412.47799.vapier@gentoo.org> (raw)
In-Reply-To: <4C778834.9030901@emk-elektronik.de>
On Friday, August 27, 2010 05:41:08 Reinhard Meyer wrote:
> Stefano Babic schrieb:
> > --- a/lib/display_options.c
> > +++ b/lib/display_options.c
> > @@ -101,7 +101,7 @@ void print_size(unsigned long long size, const char
> > *s)
> >
> > #define DEFAULT_LINE_LENGTH_BYTES (16)
> > int print_buffer (ulong addr, void* data, uint width, uint count, uint
> > linelen) {
> >
> > - uint8_t linebuf[MAX_LINE_LENGTH_BYTES + 1];
> > + uint8_t linebuf[MAX_LINE_LENGTH_BYTES + 1]
> > __attribute__((__aligned__(4)));
> >
> > uint32_t *uip = (void*)linebuf;
> > uint16_t *usp = (void*)linebuf;
> > uint8_t *ucp = (void*)linebuf;
>
> Why not just declare it as
> uint_32t linebuf[MAX_LINE_LENGTH_BYTES/4+1];
> ?
i guess that'd be another way of doing it
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100827/70be83e1/attachment.pgp
next prev parent reply other threads:[~2010-08-27 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 11:01 [U-Boot] [PATCH] Disaligned buffer in print_buffer Stefano Babic
2010-08-19 15:35 ` Mike Frysinger
2010-08-19 16:33 ` Stefano Babic
2010-08-20 7:46 ` Albert ARIBAUD
2010-08-27 9:41 ` Reinhard Meyer
2010-08-27 18:12 ` Mike Frysinger [this message]
2010-08-27 18:24 ` Stefano Babic
2010-08-27 19:06 ` Reinhard Meyer
2010-08-28 6:56 ` Albert ARIBAUD
2010-08-28 7:17 ` Reinhard Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008271412.47799.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox