From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anatolij Gustschin <agust@denx.de>
Date: Tue, 31 Aug 2010 01:02:46 +0200
Subject: [U-Boot] [PATCH] video: cfb_console: fix definition and usage
 of CURSOR_xxx macros
In-Reply-To: <1282941947-25692-1-git-send-email-timur@freescale.com>
References: <1282941947-25692-1-git-send-email-timur@freescale.com>
Message-ID: <20100831010246.42b41258@wker>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, 27 Aug 2010 15:45:47 -0500
Timur Tabi <timur@freescale.com> wrote:

> The CURSOR_ON, CURSOR_OFF, and CURSOR_SET macros are defined incorrectly.  If
> cursor support is disabled, then these macros are defined to nothing, but
> then they are used like this:
> 
> 	if (console_col < CONSOLE_COLS)
> 		CURSOR_OFF
> 	console_row++;
> 
> which was compiled like this:
> 
> 	if (console_col < CONSOLE_COLS)
> 		console_row++;
> 
> This is obviously not what was intended.
> 
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
> 
> This patch depends on
> 
> video: cfb_console: add support for 4bpp bitmaps with GDF_32BIT_X888RGB
> 
>  drivers/video/cfb_console.c |   24 ++++++++++++++----------
>  1 files changed, 14 insertions(+), 10 deletions(-)

Applied to u-boot-video/master. Thanks!

Best regards,
Anatolij