[U-Boot] [PATCH 7/8] APM82xxx: Add bluestone board support

[Stefan Roese <sr@denx.de>]

Hi Marri,

(please reply to the mailing list as well)

On Monday 30 August 2010 19:31:32 Tirumala Marri wrote:
> > > +int board_early_init_r(void)
> > > +{
> > > +	u32 bootdevice;
> > > +
> > > +	/*
> > > +	 * Clear potential errors resulting from auto-calibration.
> > > +	 * If not done, then we could get an interrupt later on when
> > > +	 * exceptions are enabled.
> > > +	 */
> > > +	set_mcsr(get_mcsr());
> > > +
> > > +	/* Reconfigure EBC here */
> > > +	bootdevice = bootdevice_selected();
> > > +	reconfigure_EBC(bootdevice);
> > 
> > Please explain why the EBC needs to be reconfigured at this stage.
> 
> [Marri]Once we are running out of ram, we are trying to change from what
> Initial bootstraps set up the EBC banks. Let me review if it is
> significantly
> Changing anything. Otherwise I will get rid of the function.

Why don't you do it as usually done. Just define the EBC register settings in 
your board header and they will get automatically written to the EBC registers 
in arch/powerpc/cpu/ppc4xx/cpu.c, cpu_init_f():

Defines in bluestone.h like this:

/* Memory Bank 0 (NOR-flash) */
#define CONFIG_SYS_EBC_PB0AP	(EBC_BXAP_BME_DISABLED		|	\
				 EBC_BXAP_TWT_ENCODE(16)	|	\
				 EBC_BXAP_BCE_DISABLE		|	\
				 EBC_BXAP_BCT_2TRANS		|	\
				 EBC_BXAP_CSN_ENCODE(1)		|	\
				 EBC_BXAP_OEN_ENCODE(1)		|	\
				 EBC_BXAP_WBN_ENCODE(1)		|	\
				 EBC_BXAP_WBF_ENCODE(1)		|	\
				 EBC_BXAP_TH_ENCODE(7)		|	\
				 EBC_BXAP_RE_DISABLED		|	\
				 EBC_BXAP_SOR_DELAYED		|	\
				 EBC_BXAP_BEM_WRITEONLY		|	\
				 EBC_BXAP_PEN_DISABLED)
#define CONFIG_SYS_EBC_PB0CR	
(EBC_BXCR_BAS_ENCODE(CONFIG_SYS_BOOT_BASE_ADDR) | \
				 EBC_BXCR_BS_16MB		|	\
				 EBC_BXCR_BU_RW			|	\
				 EBC_BXCR_BW_16BIT)

<snip>

> > > +#define CONFIG_SDRAM_INFO_EEPROM_ADDR	0x54	/* Board specific
> 
> */
> 
> > > +#define CONFIG_SDRAM16BIT_OFFSET	0x20	/* Board specific */
> > 
> > Those two defines are not used in your patches. Please remove.
> 
> [Marri]  The variable "CONFIG_SDRAM_INFO_EEPROM_ADDR" is used.
> Where " CONFIG_SDRAM16BIT_OFFSET " is not used any where.

I can't find CONFIG_SDRAM_INFO_EEPROM_ADDR either. Where is it used?
 
<snip>

> > Please fix and resubmit. Thanks.
> > 
> > Cheers,
> > Stefan
> 
> I will do the fixes and send it again.

Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de