From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH NET 2/2] Net: clarify board/cpu_eth_init calls
Date: Wed, 1 Sep 2010 13:04:52 -0400 [thread overview]
Message-ID: <201009011304.53715.vapier@gentoo.org> (raw)
In-Reply-To: <1283321104-953-2-git-send-email-biggerbadderben@gmail.com>
On Wednesday, September 01, 2010 02:05:04 Ben Warren wrote:
> + if (board_eth_init != __def_eth_init) {
> + } else if (cpu_eth_init != __def_eth_init) {
i'm not sure these changes are useful. the resolution of the symbols happens
at link time, so it isnt like gcc will be able to optimize away the default.
if anything, it'd make more sense to declare the functions as external/weak,
and then check that the pointer is not NULL. that'd save on the overhead of
having uncalled stub functions that merely return 0 in the final linked image.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100901/5982e609/attachment.pgp
next prev parent reply other threads:[~2010-09-01 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 6:05 [U-Boot] [PATCH NET 1/2] Net: Remove redundant CONFIG_NET_MULTI directives Ben Warren
2010-09-01 6:05 ` [U-Boot] [PATCH NET 2/2] Net: clarify board/cpu_eth_init calls Ben Warren
2010-09-01 17:04 ` Mike Frysinger [this message]
2010-09-01 19:13 ` Ben Warren
2010-11-14 23:01 ` Wolfgang Denk
2010-09-13 4:07 ` [U-Boot] [PATCH NET 1/2] Net: Remove redundant CONFIG_NET_MULTI directives Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009011304.53715.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox