From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] zlib: Add further watchdog reset calls
Date: Fri, 3 Sep 2010 09:10:08 +0200 [thread overview]
Message-ID: <201009030910.08643.sr@denx.de> (raw)
In-Reply-To: <m2r5hc9jzt.fsf@ohwell.denx.de>
Hi Detlev,
On Thursday 02 September 2010 18:40:38 Detlev Zundel wrote:
> > case TYPE:
> > + if (strm->outcb != Z_NULL)
> > + (*strm->outcb)(Z_NULL, 0); /* call WATCHDOG_RESET */
> >
> > if (flush == Z_BLOCK) goto inf_leave;
> >
> > case TYPEDO:
> > if (state->last) {
>
> Can you please tell me (and include in the comment) why this calls a
> watchdog reset and why you did not use a "regular plain WATCHDOG_RESET"?
I did it this way, because that's the way these watchdog reset calls have been
implemented in the U-Boot zlib version till now. Frankly I'm not sure why it
was done this way instead of using "regular plain WATCHDOG_RESET" calls.
Perhaps Wolfgang remembers the reasoning behind it.
I could change this function pointer approach to "regular plain
WATCHDOG_RESET" call though if preferred. Just let me know and I'll try to
come up with a new patch version.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2010-09-03 7:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 17:11 [U-Boot] [PATCH] zlib: Add further watchdog reset calls Stefan Roese
2010-09-02 16:40 ` Detlev Zundel
2010-09-03 7:10 ` Stefan Roese [this message]
2010-09-03 8:30 ` Wolfgang Denk
2010-09-03 11:37 ` Stefan Roese
2010-09-09 18:27 ` Wolfgang Denk
2010-09-13 9:28 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009030910.08643.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox