[U-Boot] [PATCH v2 1/2] APM82xxx: Add CPU and other peripheral support

Stefan Roese
2010-09-03T11:26:26Z

Hi Wolfgang,

On Friday 03 September 2010 10:32:53 Wolfgang Denk wrote:
> Dear Stefan Roese,
>
> In message <201009030946.22440.sr@denx.de> you wrote:
> > IIRC, then the main reason for this is the code size reduction. Using
> > your version would increase the code size quite a bit. But I concur, it
> > would be much better readable. So just let me know, and I'll try to come
> > up with a patch cleaning this up a bit.
>
> Maybe some common parts (like "AMCC PowerPC ") could be split off.

Yes, this would help a bit. I'll add this on list.

> For the rest, the compelex code needs also space, so I'm not sure
> about the end result.
>
> > As described in some comments, the problem is that some SoC's have the
> > same PVR (for example 440EP rev C and 440GR rev B have same PVR). I have
> > no idea how this identification could be solved without such ifdef's.
>
> I see.
>
> > But you are right. Some of the ifdef's can be removed. Again, this would
> > also result in a bigger image size though.
>
> Really? We should measure the effect.

I'll work on this a bit in the near future and will post my findings.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de