[U-Boot] [PATCH v2 1/2] APM82xxx: Add CPU and other peripheral support

Tirumala Marri
2010-09-02T18:01:53Z

Mr Wolfgang,

>
> On the other hand, this seems to be a 464 core, so should we not print
> 464 here?
[Marri] Interesting point, For all other processors we were printing SoC
name not the CPU core name.
APM82xxx is SoC name.

> > diff --git a/include/ppc440.h b/include/ppc440.h
> > index c807dda..b5c1832 100644
> > --- a/include/ppc440.h
> > +++ b/include/ppc440.h
>
> Hm... you are adding a number of large blocks of code, all #ifdef'ed.
>
> This is ugly, difficult to read and difficult to maintain.
>
> Why not adding a new file include/apm82xxx.h instead?
>
[Marri] If we create new file it would cause too many changes in the
common files.
When more and more APM8xxxx processors with new registers definitions
being released
At that point we can create separate file. Please suggest ?

Regards,
Marri