From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Fri, 3 Sep 2010 13:37:24 +0200
Subject: [U-Boot] [PATCH] zlib: Add further watchdog reset calls
In-Reply-To: <20100903083024.09EE2153A79@gemini.denx.de>
References: <1283274708-32533-1-git-send-email-sr@denx.de>
	<201009030910.08643.sr@denx.de>
	<20100903083024.09EE2153A79@gemini.denx.de>
Message-ID: <201009031337.25023.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On Friday 03 September 2010 10:30:24 Wolfgang Denk wrote:
> > I did it this way, because that's the way these watchdog reset calls have
> > been implemented in the U-Boot zlib version till now. Frankly I'm not
> > sure why it was done this way instead of using "regular plain
> > WATCHDOG_RESET" calls. Perhaps Wolfgang remembers the reasoning behind
> > it.
> 
> It allows to easily adjust the granularity of trigger points depending
> on data block size.

Hmmm, I fail to see how the current implementation would differ from the one 
Detlev suggested:

"outcb" is initialised with either WATCHDOG_RESET or NULL in gunzip.c. Later 
on in zlib.c, the function referenced by outcb is called if not NULL. So those 
statements:

	if (strm->outcb != Z_NULL)
		(*strm->outcb)(Z_NULL, 0);

could be replaced by:

	WATCHDOG_RESET;

Perhaps I'm missing something?

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de