From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net/eth.c call dev->write_hwaddr in eth_init
Date: Wed, 8 Sep 2010 12:07:54 -0400 [thread overview]
Message-ID: <201009081207.55654.vapier@gentoo.org> (raw)
In-Reply-To: <AANLkTimDXyA5Dj=bt+4e26aH_PhL4XYecWgZBu793kjQ@mail.gmail.com>
On Wednesday, September 08, 2010 11:06:54 John Rigby wrote:
please do not top post
> The case I am personally dealing with is one where there is no
> persistent storage
> for ethaddr. Booting from and SD card and a script is run that sets
> the ethaddr.
>
> Currently eth_init updates dev->enetaddr for each device but does not call
> dev-write_hwaddr. This seems like a bug not a policy change.
and if you read the doumentation, you'll see that you're mistaken. whatever
device you're dealing with (today) is missing a call to its own write_hwaaddr
function inside of its own init function.
if you want to fix your immediate issue, then fix that driver as implied by
the policy. if you want to improve the policy, then you need to update all
the drivers and the common code.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100908/f1e94a46/attachment.pgp
next prev parent reply other threads:[~2010-09-08 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 22:50 [U-Boot] [PATCH] net/eth.c call dev->write_hwaddr in eth_init John Rigby
2010-09-08 4:23 ` Mike Frysinger
2010-09-08 15:06 ` John Rigby
2010-09-08 16:07 ` Mike Frysinger [this message]
2010-09-08 17:11 ` John Rigby
2010-09-08 17:27 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009081207.55654.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox