From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Wed, 8 Sep 2010 12:07:54 -0400 Subject: [U-Boot] [PATCH] net/eth.c call dev->write_hwaddr in eth_init In-Reply-To: References: <1283899826-15931-1-git-send-email-john.rigby@linaro.org> <201009080023.42046.vapier@gentoo.org> Message-ID: <201009081207.55654.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, September 08, 2010 11:06:54 John Rigby wrote: please do not top post > The case I am personally dealing with is one where there is no > persistent storage > for ethaddr. Booting from and SD card and a script is run that sets > the ethaddr. > > Currently eth_init updates dev->enetaddr for each device but does not call > dev-write_hwaddr. This seems like a bug not a policy change. and if you read the doumentation, you'll see that you're mistaken. whatever device you're dealing with (today) is missing a call to its own write_hwaaddr function inside of its own init function. if you want to fix your immediate issue, then fix that driver as implied by the policy. if you want to improve the policy, then you need to update all the drivers and the common code. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20100908/f1e94a46/attachment.pgp