From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] bedbug_860.c, bedbug_603e.c: Fix return type to silence compile warnings.
Date: Wed, 08 Sep 2010 22:03:13 +0200 [thread overview]
Message-ID: <20100908200313.99686153798@gemini.denx.de> (raw)
In-Reply-To: <1282170453-16794-1-git-send-email-wd@denx.de>
In message <1282170453-16794-1-git-send-email-wd@denx.de> you wrote:
> commit 47e26b1b "cmd_usage(): simplify return code handling" caused
> the following compile warnings:
>
> bedbug_860.c: In function 'bedbug860_do_break':
> bedbug_860.c:73: warning: 'return' with a value, in function returning void
> bedbug_860.c:121: warning: 'return' with a value, in function returning void
>
> Fix the return type.
>
> Actually these files could need some cleanup - commands should
> return proper error codes, and there are coding style issues.
> => To be fixed later.
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> ---
> Changes since V1: fix other occurrences of the same issue, too.
>
> arch/powerpc/cpu/mpc8260/bedbug_603e.c | 12 ++++++++----
> arch/powerpc/cpu/mpc8xx/bedbug_860.c | 12 ++++++++----
> 2 files changed, 16 insertions(+), 8 deletions(-)
Aplied.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What we anticipate seldom occurs; what we least expect generally
happens. - Bengamin Disraeli
prev parent reply other threads:[~2010-09-08 20:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 18:53 [U-Boot] [PATCH] bedbug_860.c: Fix return type to silence compile warnings Wolfgang Denk
2010-08-18 22:27 ` [U-Boot] [PATCH V2] bedbug_860.c, bedbug_603e.c: " Wolfgang Denk
2010-09-08 20:03 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100908200313.99686153798@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox