From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4 v2] cfi_flash: Add weak default for cfi_flash_bank_addr()
Date: Thu, 9 Sep 2010 12:53:50 +0200 [thread overview]
Message-ID: <201009091253.50411.sr@denx.de> (raw)
In-Reply-To: <20100909104213.E5908153798@gemini.denx.de>
Hi Wolfgang,
On Thursday 09 September 2010 12:42:13 Wolfgang Denk wrote:
> > cfi_flash_bank_addr(int bank_nr) returns the base addresses of the
> > requested bank. Introducing this weak default enables boards to override
> > this functions with a board specific version when required.
>
> ..
>
> > + return ((phys_addr_t [])CONFIG_SYS_FLASH_BANKS_LIST)[i];
>
> ..
>
> > -#define BANK_BASE(i) (((phys_addr_t
> > [CFI_MAX_FLASH_BANKS])CONFIG_SYS_FLASH_BANKS_LIST)[i])
>
> Was the change from "[CFI_MAX_FLASH_BANKS]" to "[]" intentional?
Yes. Do you see a problem with this change?
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2010-09-09 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 10:06 [U-Boot] [PATCH 2/4 v2] cfi_flash: Add weak default for cfi_flash_bank_addr() Stefan Roese
2010-09-09 10:42 ` Wolfgang Denk
2010-09-09 10:53 ` Stefan Roese [this message]
2010-09-09 11:57 ` Wolfgang Denk
2010-09-09 12:37 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009091253.50411.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox