From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support
Date: Thu, 9 Sep 2010 16:45:15 +0200 [thread overview]
Message-ID: <201009091645.16076.sr@denx.de> (raw)
In-Reply-To: <1283911581-16085-1-git-send-email-tmarri@apm.com>
Hi Marri,
On Wednesday 08 September 2010 04:06:21 tmarri at apm.com wrote:
> From: Tirumala Marri <tmarri@apm.com>
>
> APM821XX is a new line of SoCs which are derivatives of
> PPC44X family of processors. This patch adds support of CPU, cache,
> tlb, 32k ocm, bootstraps, PLB and AHB bus.
Look mostly good. One comment though below.
> Signed-off-by: Tirumala R Marri <tmarri@apm.com>
> ---
> V2:
> * Removed Defines added to 405ex.
> V3:
> * Change APM82XXX to APM821XX
> * Modify the way cpu id is printed.
> * Correct inadvertent change.
> * Sort define list.
> * Remove comment for get_sys_info().
> * Define a symbolic constat ISRAM1_OCM_SIZE.
> * Create apm821xx.h instead of using ppc440.h
> * Correct multiline comment.
> ---
> arch/powerpc/cpu/ppc4xx/cpu.c | 36 ++-
> arch/powerpc/cpu/ppc4xx/cpu_init.c | 5 +-
> arch/powerpc/cpu/ppc4xx/speed.c | 76 +++++-
> arch/powerpc/cpu/ppc4xx/start.S | 11 +-
> arch/powerpc/cpu/ppc4xx/tlb.c | 2 +
> arch/powerpc/include/asm/ppc4xx-ebc.h | 4 +
> arch/powerpc/include/asm/ppc4xx-isram.h | 14 +-
> arch/powerpc/include/asm/ppc4xx-sdram.h | 12 +-
> arch/powerpc/include/asm/ppc4xx-uic.h | 5 +-
> arch/powerpc/include/asm/processor.h | 1 +
> include/apm821xx.h | 493 +++++++++++++++++++++++++++++++
I know that Wolfgang specifically asked you to add this file for this
"new" SoC. But I'm not so sure if this is the right way. Most of the
defines in this new file are a plain copy from include/ppc440.h.
Wolfgang, do you really think this is better than adding support for
this SoC into ppc440.h? After all, the CPU core of this SoC is still
a PPC4xx PowerPC.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2010-09-09 14:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 2:06 [U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support tmarri at apm.com
2010-09-09 14:45 ` Stefan Roese [this message]
2010-09-09 14:53 ` Wolfgang Denk
2010-09-09 16:43 ` Tirumala Marri
2010-09-09 17:39 ` Stefan Roese
2010-09-09 17:41 ` Tirumala Marri
2010-09-09 18:01 ` Feng Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009091645.16076.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox