From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/2] APM821xx: Add bluestone board support
Date: Thu, 9 Sep 2010 16:50:34 +0200 [thread overview]
Message-ID: <201009091650.34625.sr@denx.de> (raw)
In-Reply-To: <1283911587-16126-1-git-send-email-tmarri@apm.com>
Hi Marri,
On Wednesday 08 September 2010 04:06:27 tmarri at apm.com wrote:
> From: Tirumala Marri <tmarri@apm.com>
>
> Add support code for bluestone board wth APM821XX processor based.
> This patch includes early board init, misc init, configure EBC,
> initializes UIC, MAKEALL, board.cfg and MAINTAINERS file.
One nitpicking comment below.
<snip>
> +/*
> + * Ethernet
> + */
> +#define CONFIG_IBM_EMAC4_V4 1
> +#define CONFIG_EMAC_PHY_MODE EMAC_PHY_MODE_NONE_RGMII
> +#define CONFIG_HAS_ETH0
> +/* PHY address, See schematics */
> +#define CONFIG_PHY_ADDR 0x1f
> +/* reset phy upon startup */
> +#define CONFIG_PHY_RESET 1
> +#define CONFIG_PHY_RESET_R
CONFIG_PHY_RESET_R is not referenced anywhere. Please remove it.
Please fix and resubmit. Thanks.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
prev parent reply other threads:[~2010-09-09 14:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 2:06 [U-Boot] [PATCH v3 2/2] APM821xx: Add bluestone board support tmarri at apm.com
2010-09-09 14:50 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009091650.34625.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox