From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Thu, 9 Sep 2010 16:50:34 +0200
Subject: [U-Boot] [PATCH v3 2/2] APM821xx: Add bluestone board support
In-Reply-To: <1283911587-16126-1-git-send-email-tmarri@apm.com>
References: <1283911587-16126-1-git-send-email-tmarri@apm.com>
Message-ID: <201009091650.34625.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marri,

On Wednesday 08 September 2010 04:06:27 tmarri at apm.com wrote:
> From: Tirumala Marri <tmarri@apm.com>
> 
> Add support code for bluestone board wth APM821XX processor based.
> This patch includes early board init, misc init, configure EBC,
> initializes UIC, MAKEALL, board.cfg and MAINTAINERS file.

One nitpicking comment below.

<snip>
 
> +/*
> + * Ethernet
> + */
> +#define CONFIG_IBM_EMAC4_V4    1
> +#define CONFIG_EMAC_PHY_MODE  EMAC_PHY_MODE_NONE_RGMII
> +#define CONFIG_HAS_ETH0
> +/* PHY address, See schematics  */
> +#define CONFIG_PHY_ADDR			0x1f
> +/* reset phy upon startup       */
> +#define CONFIG_PHY_RESET		1
> +#define CONFIG_PHY_RESET_R

CONFIG_PHY_RESET_R is not referenced anywhere. Please remove it.

Please fix and resubmit. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de