public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] zlib: Add further watchdog reset calls
Date: Thu, 09 Sep 2010 20:27:08 +0200	[thread overview]
Message-ID: <20100909182708.233B1153798@gemini.denx.de> (raw)
In-Reply-To: <1283274708-32533-1-git-send-email-sr@denx.de>

Dear Stefan Roese,

In message <1283274708-32533-1-git-send-email-sr@denx.de> you wrote:
> Patch 253cb831 [zlib: add watchdog reset call] added already a few
> watchdog reset calls to the new zlib U-Boot port. But on some boards
> this is not enough. Additional calls are needed on boards with
> short watchdog timeouts.
> 
> This was detected and tested on the lwmon5 board with a very short
> watchdog timeout. Without this patch, the board resets during Linux
> kernel decompression. With it, the decompression succeeds.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  lib/zlib.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/zlib.c b/lib/zlib.c
> index 26e5af1..39d5dab 100644
> --- a/lib/zlib.c
> +++ b/lib/zlib.c
> @@ -1599,6 +1599,8 @@ int flush;
>              strm->adler = state->check = adler32(0L, Z_NULL, 0);
>              state->mode = TYPE;
>          case TYPE:
> +         if (strm->outcb != Z_NULL)
> +                 (*strm->outcb)(Z_NULL, 0); /* call WATCHDOG_RESET */
>              if (flush == Z_BLOCK) goto inf_leave;

Indentation wrong?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is a theory which states that if ever anyone discovers  exactly
what  the  Universe is for and why it is here, it will instantly dis-
appear and be replaced by something even more  bizarre  and  inexpli-
cable.  There  is  another  theory which states that this has already
happened.    -- Douglas Adams, "The Hitchhiker's Guide to the Galaxy"

  parent reply	other threads:[~2010-09-09 18:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-31 17:11 [U-Boot] [PATCH] zlib: Add further watchdog reset calls Stefan Roese
2010-09-02 16:40 ` Detlev Zundel
2010-09-03  7:10   ` Stefan Roese
2010-09-03  8:30     ` Wolfgang Denk
2010-09-03 11:37       ` Stefan Roese
2010-09-09 18:27 ` Wolfgang Denk [this message]
2010-09-13  9:28   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100909182708.233B1153798@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox