[U-Boot] [PATCH] powerpc: Cleanup BOOTFLAG_* usage

Peter Tyser
2010-09-13T14:53:05Z

On Mon, 2010-09-13 at 08:27 +0200, Stefan Roese wrote:
> On Monday 13 September 2010 07:34:40 Wolfgang Denk wrote:
> > > BOOTFLAG_COLD and BOOTFLAG_WARM have identical definitions for every
> > > PowerPC board, so share a common definition.
> > >
> > > Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> > > ---
> > > It looks like there are only a few boards (5) that use the warm/cold
> > > boot concept, maybe we should remove this largely unused feature?
> > > Or at least remove it for most CPU types? Is anyone out there
> > > using it?
> >
> > I added this with the very first versions of PPCBoot, more than a
> > decade ago. I've never seen it really used in the code.
> >
> > I vote for removing it.
>
> Me too:
>
> Acked-by: Stefan Roese <sr@denx.de>

Sounds good, I'll resubmit. Getting rid of the BOOTFLAG_* defines will
make bd->bi_bootflags unused. What's the policy on modifying the
bd_info structure? Leave an unused bi_bootflags field to prevent
breakage of OSes?

Best,
Peter